After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664260 - [WEB] Remove editable toolbars functionality
[WEB] Remove editable toolbars functionality
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 664483
 
 
Reported: 2011-11-17 11:53 UTC by Xan Lopez
Modified: 2011-12-10 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove the toolbar editor UI (19.39 KB, patch)
2011-11-21 12:04 UTC, Xan Lopez
none Details | Review

Description Xan Lopez 2011-11-17 11:53:00 UTC
We are in the process of defining the future Epiphany UI these days. One thing that seems clear, though, is that regardless of where we go the ability to edit the toolbars does not really fit with any future design or even with the rest of the current GNOME core applications (AFAIK we are the only one that allows this). After talking with some designers they pretty much agree with this sentiment, so I'm proposing to just remove the code ahead of time to simplify the codebase for the future refactorings.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2011-11-20 19:51:20 UTC
Agree. Let's just have a good story for the new toolbar so it's not apocalypse.
Comment 2 Claudio Saavedra 2011-11-21 11:19:05 UTC
FWIW, eog also allows for this, but it's likely to be less of a relevant feature soon..
Comment 3 Xan Lopez 2011-11-21 12:04:46 UTC
Created attachment 201796 [details] [review]
Remove the toolbar editor UI

First step, just remove the UI.

I think we can get rid of all the Egg* stuff, but it's a bit tangled into all the code so it's not trivial.
Comment 4 Xan Lopez 2011-12-10 16:50:44 UTC
This was committed in master, so we can close the bug.