After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664216 - Hide password entry if the VM is not password protected
Hide password entry if the VM is not password protected
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-16 18:05 UTC by Cosimo Cecchi
Modified: 2016-03-31 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Hide password entry if the VM is not password protected (1.08 KB, patch)
2011-11-16 18:21 UTC, Marc-Andre Lureau 		accepted-commit_now Details | Review

Description Cosimo Cecchi 2011-11-16 18:05:18 UTC 
When clicking on a VM in the overview page, there's a nice animation that scales up its thumbnail before switching to the real VM window.
While the animation is in progress, I see a "Password" entry below the scaled up thumbnail; this should be shown only if the VM needs a password.
Comment 1 Marc-Andre Lureau 2011-11-16 18:21:00 UTC 
Created attachment 201557 [details] [review]
Hide password entry if the VM is not password protected
Comment 2 Cosimo Cecchi 2011-11-16 19:21:19 UTC 
Comment on attachment 201557 [details] [review]
Hide password entry if the VM is not password protected

Seems to work great :)
Comment 3 Marc-Andre Lureau 2011-11-17 00:35:08 UTC 
I actually pushed it along with another password fix.


commit 8ef80d81b0bad3754db65505504c3fcdc80911c5
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Thu Nov 17 01:28:56 2011 +0100

    Fix connect to libvirt machine with password

commit c35334bf64f391ed7e59d746f629d5ecde9945f3
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Wed Nov 16 19:20:37 2011 +0100

    Hide password entry if the VM is not password protected
    
    https://bugzilla.gnome.org/show_bug.cgi?id=664216
Comment 4 Marc-Andre Lureau 2011-11-17 00:36:32 UTC 
(In reply to comment #0)
> When clicking on a VM in the overview page, there's a nice animation that
> scales up its thumbnail before switching to the real VM window.
> While the animation is in progress, I see a "Password" entry below the scaled
> up thumbnail; this should be shown only if the VM needs a password.

in theory we should have a prettier zoom-in effect, I didn't get around of retriving the item geometry from the iconview yet, but it should get more fancy later ;)