After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664213 - VM toolbar fades in too eagerly
VM toolbar fades in too eagerly
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-16 17:53 UTC by Cosimo Cecchi
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Show VM toolbar with a bit more delay or when reaching top (1.26 KB, patch)
2011-11-16 18:03 UTC, Marc-Andre Lureau
committed Details | Review

Description Cosimo Cecchi 2011-11-16 17:53:26 UTC
When you're inside a VM, the toolbar should not fade in that soon if you move the mouse in the top area, since many OSes put an important panel up there; the toolbar makes it really hard to use it.

My advice is to move in the toolbar only after the actual top of the preview window has been touched, maybe after a timeout as well.
Comment 1 Marc-Andre Lureau 2011-11-16 18:01:53 UTC
it's very much hard-coded right now, becuase we are missing a few guidelines, and the topbar should appear progressively in transparency (probably leting pointer events pass-through until it reaches full opacity)

Try the following commit please :)
Comment 2 Marc-Andre Lureau 2011-11-16 18:03:46 UTC
Created attachment 201556 [details] [review]
Show VM toolbar with a bit more delay or when reaching top
Comment 3 Marc-Andre Lureau 2011-11-16 18:08:17 UTC
we may want to have that 20 pixels region only in window mode. Rationale:

- it's easy to reach top border / pixel 0 in fullscreen, and we don't want to annoy  users with the topbar when the pointer is near the top

- it's difficult to reach pixel 0 in window mode, but we don't want to show toolbar immediately either
Comment 4 Cosimo Cecchi 2011-11-16 19:19:26 UTC
The patch improves this a lot for easy operations, but it's still not ideal IMHO.

I'm not a fan of changing opacity based on pointer position, but ignoring that for a moment, I think a better behaviour for window mode would be making the area thinner (you would have to play with the exact size, but e.g. the shell panel is 25px so 20px sounds too much...maybe 5px?) and always move in the toolbar when it's reached.

I agree for fullscreen mode this doesn't make sense and the toolbar should always just move in when the top of the window is reached.
Comment 5 Marc-Andre Lureau 2011-11-18 00:51:44 UTC
Attachment 201556 [details] pushed as 53bdd79 - Show VM toolbar with a bit more delay or when reaching top
Comment 6 Marc-Andre Lureau 2011-11-18 00:52:11 UTC
we will revisit the topbar when adding opacity & animation support