GNOME Bugzilla – Bug 664201
"New workspace" indicator sometimes gets stuck
Last modified: 2012-01-17 15:24:56 UTC
In the workspace switcher, a "new workspace" indicator is shown when dragging a window between two existing workspaces; the indicator is only removed when hovering a workspace preview, but not when leaving the switcher (e.g. when returning the window to the window previews area)
Created attachment 201750 [details] [review] various fixes Hi, the patch contains a fix for this bug and a couple of minor misbehaviors: 1. "Bouncing" of the placeholder when dragging something above the first thumbnail 2. The cursor is not always updated correctly and the drop targets are somewhat incorrect because coordinates relative to the actor are treated as stage coordinates.
Created attachment 201985 [details] [review] hide the placeholder when pointer is not hovering
the other bugs are reported here: https://bugzilla.gnome.org/show_bug.cgi?id=664625 https://bugzilla.gnome.org/show_bug.cgi?id=664622
Created attachment 202057 [details] [review] hide the placeholder when pointer is not inside the pager maybe imitating the Dash is a better, self-contained approach
Created attachment 202060 [details] [review] hide the placeholder when pointer is not inside the pager forgot to remove the drag monitor... sorry for the noise
Created attachment 202245 [details] [review] workspaceThumbnail: add a drag monitor and give a chance to do something on leave This is useful to clear the drop placeholder when the pointer leaves the selector. It will also be used to handle a drop target indicator.
Review of attachment 202245 [details] [review]: Looks right to me - the commit message (in particular the subject) could use some improvements before committing (the drag monitor is more of an implementation detail and probably better off in the body, and "do something" is a tad bit generic ;-)
Created attachment 204075 [details] [review] workspaceThumbnail: clear the drop placeholder when pointer leaves the selector We add a drag monitor to check whether the pointer is inside the workspace selector, and update the visibility of the drop placeholder consequently.
Created attachment 204077 [details] [review] workspaceThumbnail: clear the drop placeholder when pointer leaves the selector We add a drag monitor to check whether the pointer is inside the workspace selector, and update the visibility of the drop placeholder consequently.
Created attachment 205447 [details] [review] workspaceThumbnail: clear the drop placeholder on pointer leave We add a drag monitor to check whether the pointer is inside the workspace selector, and update the visibility of the drop placeholder consequently.
Attachment 205447 [details] pushed as f59018f - workspaceThumbnail: clear the drop placeholder on pointer leave
Yay, thanks for the patch Stefano!