After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664185 - Tarballs contain bad Exec lines in .desktop.in files
Tarballs contain bad Exec lines in .desktop.in files
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-16 10:47 UTC by Vincent Untz
Modified: 2011-12-19 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vincent Untz 2011-11-16 10:47:02 UTC
$ grep Exec *desktop.in
gnome-keyring-gpg.desktop.in:Exec= gnome-keyring-daemon --start --components=gpg
gnome-keyring-pkcs11.desktop.in:Exec=/data/build/gnome/bin/gnome-keyring-daemon --start --components=pkcs11
gnome-keyring-secrets.desktop.in:Exec=/data/build/gnome/bin/gnome-keyring-daemon --start --components=secrets
gnome-keyring-ssh.desktop.in:Exec=/data/build/gnome/bin/gnome-keyring-daemon --start --components=ssh

The /data/build/gnome/bin prefix is bad, as it might end in packages...
Comment 1 Stef Walter 2011-11-23 17:27:50 UTC
I *hate* how ${prefix} is expanded late in autotools. :(
Comment 2 Matthias Clasen 2011-11-24 20:15:34 UTC
Can I propose that we move away from autostart files for gnome-keyring components altogether, and instead use the 'required session components' mechanism ?

We really want to be moving away from using autostart for desktop infrastructure.
Comment 3 Stef Walter 2011-11-24 20:30:37 UTC
Do you have a link? It sounds good for certain parts of gnome-keyring.

But its important to note that the GPG and SSH agents in particular are optional, mostly because they don't yet have all the functionality of their console counterparts.
Comment 4 Stef Walter 2011-12-19 08:51:31 UTC
commit 27e27ed41f4c5e1739c7dd259105b6a20f3528d4
Author: Stef Walter <stefw@collabora.co.uk>
Date:   Mon Dec 19 09:50:27 2011 +0100

    daemon: Distribute correct desktop autostart files
    
     * Distribute xxx.in.in files instead of xxx.in files
    
    https://bugzilla.gnome.org/show_bug.cgi?id=664185