After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664154 - 3.4: Add Boxes & its deps
3.4: Add Boxes & its deps
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2011-11-15 22:59 UTC by Zeeshan Ali
Modified: 2011-11-16 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
3.4: Add Boxes & its deps (5.66 KB, patch)
2011-11-15 22:59 UTC, Zeeshan Ali 		none Details | Review
3.4: Add Boxes & its deps (5.52 KB, patch)
2011-11-15 23:36 UTC, Zeeshan Ali 		committed Details | Review
3.4: Add Boxes & its deps (5.50 KB, patch)
2011-11-16 14:47 UTC, Zeeshan Ali 		none Details | Review

Description Zeeshan Ali 2011-11-15 22:59:29 UTC 
Add gnome-boxes to jhbuild along with all its dependencies.
Comment 1 Zeeshan Ali 2011-11-15 22:59:31 UTC 
Created attachment 201488 [details] [review]
3.4: Add Boxes & its deps
Comment 2 Zeeshan Ali 2011-11-15 23:36:33 UTC 
Created attachment 201492 [details] [review]
3.4: Add Boxes & its deps
Comment 3 Colin Walters 2011-11-16 14:40:53 UTC 
Review of attachment 201492 [details] [review]:

Two comments:

::: modulesets/gnome-apps-3.4.modules
@@ +178,3 @@
+    <source href="http://download.gnome.org/sources/gtk-vnc/0.4/gtk-vnc-0.4.4.tar.bz2"
+            hash="sha256:56e02a83718dc0485ba0dd8f1a6656e60b9ab503b2c78187a3a6724f6c413a64"
+            md5sum="0c51bcbdf1530c4856f49ace7c8f709a" size="456119"/>

This could probably be a separate patch "Update gtk-vnc to 0.4.4"

::: modulesets/gnome-suites-core-deps-3.4.modules
@@ +1396,3 @@
+  <tarball id="spice-server"
+             version="0.10.0"
+             autogenargs="--enable-werror --disable-smartcard --without-sasl --disable-client" >

No -Werror in jhbuild, or else you get to debug problems Summer of Code students hit because they have newer/older gcc versions than you do.
Comment 4 Zeeshan Ali 2011-11-16 14:47:06 UTC 
Created attachment 201547 [details] [review]
3.4: Add Boxes & its deps
Comment 5 Javier Jardón (IRC: jjardon) 2011-11-16 14:49:53 UTC 
Comment on attachment 201492 [details] [review]
3.4: Add Boxes & its deps

commit 0893034f24f61bd97e06b4761094bf2d7cb49a34

I've added all the modules in -apps, as core-deps is only for dependencies of -core