GNOME Bugzilla – Bug 664150
Fix unboxing of integer GValues for property access
Last modified: 2012-02-06 17:55:03 UTC
We need to use the correct value accessors for schar/uchar types.
Created attachment 201484 [details] [review] Fix unboxing of uchar/schar GValues for property access
Comment on attachment 201484 [details] [review] Fix unboxing of uchar/schar GValues for property access Could someone merge the test case into the test suite? Ideally there would be a single patch. Thanks!
Comment on attachment 201484 [details] [review] Fix unboxing of uchar/schar GValues for property access Could someone add a test case? Ideally there would be a single patch. Thanks!
This is similar to bug 666677, gimarshallingtests.c from gobject-introspection should cover this case.
*** Bug 666677 has been marked as a duplicate of this bug. ***
Created attachment 206809 [details] [review] Test cases for gobject-introspection
Created attachment 206810 [details] [review] Fix unboxing for integer types Retrieving "char" type properties does not work because somehow gobject-introspection thinks it is has a guint8 type tag.
The patches look fine to me. It would be good if add the bug URL to the commit log when pushing those. For the bool case, I'd recommend not commenting out the test case, and do @unittest.expectedFailure def test_char(self): instead. That way, it stands out during running the tests as a real TODO item, but won't break distcheck or count as real failure. Thanks!
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.