After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664085 - Portability fixes
Portability fixes
Status: RESOLVED FIXED
Product: libxslt
Classification: Platform
Component: general
1.1.26
Other FreeBSD
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-15 02:02 UTC by giffunip
Modified: 2012-08-16 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
BSD patch (990 bytes, patch)
2011-11-15 02:02 UTC, giffunip 		none Details | Review
Portability fixes (1.06 KB, patch)
2012-02-02 22:03 UTC, giffunip 		none Details | Review

Description giffunip 2011-11-15 02:02:55 UTC 
Created attachment 201415 [details] [review]
BSD patch

These come from the FreeBSD port, with minor adjustments.
The idea is to avoid glibc workarounds on platforms that
don't need them.
Comment 1 André Klapper 2012-02-02 21:12:08 UTC 
Comment on attachment 201415 [details] [review]
BSD patch

[Setting "patch" flag and correcting mime type so this can actually be queried for.]
Comment 2 giffunip 2012-02-02 22:03:08 UTC 
Created attachment 206665 [details] [review]
Portability fixes

Actually the second part of the part caused problems on Solaris so it's better to restrict it only to FreeBSD where it's known to work.
Comment 3 giffunip 2012-02-02 22:04:10 UTC 
(In reply to comment #2)
> Created an attachment (id=206665) [details] [review]
> Portability fixes
> 
> Actually the second part of the part caused problems on Solaris so it's better
> to restrict it only to FreeBSD where it's known to work.

I meant the second part of the *patch*.
Comment 4 Daniel Veillard 2012-08-16 13:25:07 UTC 
That looks fine and safe !

  Applied:
http://git.gnome.org/browse/libxslt/commit/?id=bda37db361159222a9ecd05237c05b839c3f2654

  thanks a lot !

Daniel