After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664041 - Search field in the overview does not support preedit
Search field in the overview does not support preedit
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 680312 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-11-14 14:50 UTC by Jan Arne Petersen
Modified: 2012-08-29 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-im-text: Support pre-edit (3.18 KB, patch)
2012-08-22 09:06 UTC, Daiki Ueno
none Details | Review
st-im-text: Support pre-edit (2.74 KB, patch)
2012-08-23 01:03 UTC, Daiki Ueno
committed Details | Review

Description Jan Arne Petersen 2011-11-14 14:50:44 UTC
Using IBus (Pinyin) in the search field in the overview there is no preedit shown, which makes it (together with bug 664040) nearly impossible to properly enter anything in that field.
Comment 1 Daiki Ueno 2012-08-22 09:06:47 UTC
Created attachment 222114 [details] [review]
st-im-text: Support pre-edit

Use clutter_text_set_preedit_string() to wedge pre-edit text
into ClutterText.  Note that the function does not make a
copy of pre-edit string, StIMText needs to maintain the memory
allocated for pre-edit string (and attributes) until the object
is finalized.
Comment 2 Daiki Ueno 2012-08-22 11:41:45 UTC
(In reply to comment #1)

> Note that the function does not make a
> copy of pre-edit string, StIMText needs to maintain the memory
> allocated for pre-edit string (and attributes) until the object
> is finalized.

Doh, that's not true - I misread the doc.
Will add a revised (simplified) patch soon.
Comment 3 Daiki Ueno 2012-08-23 01:03:07 UTC
Created attachment 222200 [details] [review]
st-im-text: Support pre-edit

Use clutter_text_set_preedit_string() to wedge pre-edit text
into ClutterText.
Comment 4 Rui Matos 2012-08-27 14:21:27 UTC
Review of attachment 222200 [details] [review]:

Thanks for the patch.

Looks good besides the unused variable.

Do you have commit access? Otherwise I can push. Don't bother about submitting a new patch without the unused variable, just push without it or I can do that too.

::: src/st/st-im-text.c
@@ +152,3 @@
+{
+  ClutterText *clutter_text = CLUTTER_TEXT (imtext);
+  StIMTextPrivate *priv = imtext->priv;

'priv' isn't used
Comment 5 Rui Matos 2012-08-27 16:15:31 UTC
*** Bug 680312 has been marked as a duplicate of this bug. ***
Comment 6 Daiki Ueno 2012-08-27 21:25:48 UTC
(In reply to comment #4)
> Looks good besides the unused variable.
> 
> Do you have commit access? Otherwise I can push.

No, I don't.  Please commit.
Thanks for the review and correction.
Comment 7 Rui Matos 2012-08-29 12:57:26 UTC
Attachment 222200 [details] pushed as ee60863 - st-im-text: Support pre-edit