GNOME Bugzilla – Bug 664031
GCONF_DEFAULT_SOURCE_PATH support broken in dbus backend
Last modified: 2011-11-29 13:45:02 UTC
Commit 7baf4c6b33a6dd0697a8bdb81bd86c72d58ebdc6 introduced support for overriding the default config via $GCONF_DEFAULT_SOURCE_PATH. This allows tools like jhbuild to tell GConf about additional places to search for defaults and settings, so that installing applications (including their GConf schema files) into and running them from a non-system directory works as expected. This support was originally added to gconf_engine_get_default() in the ORBit "backend", and most likely continues to work fine there. However the gconf_engine_get_default() in the DBus backend (introduced by eed7b085e64f425bac72ec5f9f0634fdb35176d3) lacks this support, so when --disable-orbit is used (as Debian does) GCONF_DEFAULT_SOURCE_PATH won't work anymore.
Downstream bug: Debian#648724 [1] [1] http://bugs.debian.org/648724
Created attachment 201398 [details] [review] D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support Forward-port 7baf4c6b33a6dd0697a8bdb81bd86c72d58ebdc6 ("Allow overriding the default config via $GCONF_DEFAULT_SOURCE_PATH") from the ORBit to the D-Bus backend to fix (sugar-)jhbuild breakage when building with --disable-orbit.
Review of attachment 201398 [details] [review]: LGTM. Ross ?
Thanks for the review, Rob. Is there anything else I need to or should do to get this landed?
The following fix has been pushed: c129898 D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support (#664031)
Created attachment 202295 [details] [review] D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support (#664031) Forward-port 7baf4c6b33a6dd0697a8bdb81bd86c72d58ebdc6 ("Allow overriding the default config via $GCONF_DEFAULT_SOURCE_PATH") from the ORBit to the D-Bus backend to fix (sugar-)jhbuild breakage when building with --disable-orbit.
Thanks!