After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664031 - GCONF_DEFAULT_SOURCE_PATH support broken in dbus backend
GCONF_DEFAULT_SOURCE_PATH support broken in dbus backend
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
3.2.x
Other All
: Normal major
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-14 13:41 UTC by Sascha Silbe
Modified: 2011-11-29 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support (2.87 KB, patch)
2011-11-14 20:37 UTC, Sascha Silbe
reviewed Details | Review
D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support (#664031) (2.87 KB, patch)
2011-11-28 14:32 UTC, Ross Burton
committed Details | Review

Description Sascha Silbe 2011-11-14 13:41:10 UTC
Commit 7baf4c6b33a6dd0697a8bdb81bd86c72d58ebdc6 introduced support for overriding the default config via $GCONF_DEFAULT_SOURCE_PATH. This allows tools like jhbuild to tell GConf about additional places to search for defaults and settings, so that installing applications (including their GConf schema files) into and running them from a non-system directory works as expected.

This support was originally added to gconf_engine_get_default() in the ORBit "backend", and most likely continues to work fine there. However the gconf_engine_get_default() in the DBus backend (introduced by eed7b085e64f425bac72ec5f9f0634fdb35176d3) lacks this support, so when --disable-orbit is used (as Debian does) GCONF_DEFAULT_SOURCE_PATH won't work anymore.
Comment 1 Sascha Silbe 2011-11-14 14:45:20 UTC
Downstream bug: Debian#648724 [1]

[1] http://bugs.debian.org/648724
Comment 2 Sascha Silbe 2011-11-14 20:37:40 UTC
Created attachment 201398 [details] [review]
D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support

Forward-port 7baf4c6b33a6dd0697a8bdb81bd86c72d58ebdc6
("Allow overriding the default config via $GCONF_DEFAULT_SOURCE_PATH")
from the ORBit to the D-Bus backend to fix (sugar-)jhbuild breakage when
building with --disable-orbit.
Comment 3 Rob Bradford 2011-11-15 11:01:50 UTC
Review of attachment 201398 [details] [review]:

LGTM. Ross ?
Comment 4 Sascha Silbe 2011-11-25 21:07:31 UTC
Thanks for the review, Rob. Is there anything else I need to or should do to get this landed?
Comment 5 Ross Burton 2011-11-28 14:32:38 UTC
The following fix has been pushed:
c129898 D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support (#664031)
Comment 6 Ross Burton 2011-11-28 14:32:41 UTC
Created attachment 202295 [details] [review]
D-Bus backend: Add GCONF_DEFAULT_SOURCE_PATH support (#664031)

Forward-port 7baf4c6b33a6dd0697a8bdb81bd86c72d58ebdc6
("Allow overriding the default config via $GCONF_DEFAULT_SOURCE_PATH")
from the ORBit to the D-Bus backend to fix (sugar-)jhbuild breakage when
building with --disable-orbit.
Comment 7 Sascha Silbe 2011-11-29 13:45:02 UTC
Thanks!