After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663899 - gxps_parse_error INVALID_CONTENT error has element and attribute switched
gxps_parse_error INVALID_CONTENT error has element and attribute switched
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-12 01:53 UTC by Jason Crain
Modified: 2011-11-12 08:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixed attribute_name and element_name being switched in gxps_parse_error (1.07 KB, patch)
2011-11-12 01:53 UTC, Jason Crain 		committed Details | Review

Description Jason Crain 2011-11-12 01:53:06 UTC 
Created attachment 201270 [details] [review]
Fixed attribute_name and element_name being switched in gxps_parse_error

When gxps_parse_error is called with error_type G_MARKUP_ERROR_INVALID_CONTENT, the GError message produced has the attribute_name and element_name switched.  For example, this creates the following error message:

Error rendering page /Documents/1/Pages/1.fpage: /Documents/1/Pages/1.fpage:4:55 invalid content in attribute 'Opacity' of element 'SolidColorBrush': abc
Comment 1 Jason Crain 2011-11-12 01:59:13 UTC 
Correction: Without the patch, produces this incorrect error message:

Error rendering page /Documents/1/Pages/1.fpage: /Documents/1/Pages/1.fpage:4:55 invalid content in attribute 'SolidColorBrush' of element 'Opacity': abc
Comment 2 Carlos Garcia Campos 2011-11-12 08:27:50 UTC 
Review of attachment 201270 [details] [review]:

Now I understand why you switched attribute and element in previous patch :-P Thanks for the patch, I've just pushed it to git master.