After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663890 - @throws annotations missing for some functions
@throws annotations missing for some functions
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: documentation
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-11 23:46 UTC by Travis Reitter
Modified: 2012-04-25 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Travis Reitter 2011-11-11 23:46:18 UTC
At a glance, all of the functions in IndividualAggregator that throw errors fail to include an @throws annotation. It's possible this is true in other files as well.
Comment 1 Philip Withnall 2012-04-23 23:06:14 UTC
Well that was fun.

commit 896c6741572359d870bb7ff04224ce8535b1ec78
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Apr 24 00:02:43 2012 +0100

    Bug 663890 — @throws annotations missing for some functions
    
    Add missing ‘@throws’ annotations to various public methods.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=663890

 NEWS                                             |    1 +
 backends/eds/lib/edsf-persona-store.vala         |   18 +++++++++++++
 backends/key-file/kf-persona-store.vala          |    3 ++
 backends/libsocialweb/lib/swf-persona-store.vala |   10 +++++++
 backends/telepathy/lib/tpf-persona-store.vala    |   12 +++++++++
 backends/telepathy/lib/tpf-persona.vala          |    3 ++
 backends/tracker/lib/trf-persona-store.vala      |    7 +++++
 folks/backend-store.vala                         |    2 +
 folks/backend.vala                               |    4 +++
 folks/group-details.vala                         |    2 +
 folks/individual-aggregator.vala                 |   29 ++++++++++++++++++++++
 folks/persona-store.vala                         |    6 ++++
 12 files changed, 97 insertions(+), 0 deletions(-)
Comment 2 Philip Withnall 2012-04-25 21:29:24 UTC
Bleh. Forgot to push. Commit ID is now 186a237ba31d9bb392a48511ab2b95bdb4352d2c.