GNOME Bugzilla – Bug 663873
Massive memory leaks in Previous Conversations
Last modified: 2018-05-22 15:13:19 UTC
While writing up the various component bugs for bug #663870, my Empathy memory usage got to 4 GiB virtual memory, 2.3 GiB resident memory. It continued to grow when switching the selection in the Who/What/When columns, so a lot of memory isn't being properly freed. Opening the dialog for the first time leaks about 300 MiB (which is impressive considering my Telepathy logger files only total 128 MiB). Furthermore, the memory isn't freed after closing the log viewer window.
Created attachment 201358 [details] [review] empathy-logs: port to TP coding style
Created attachment 201359 [details] [review] empathy-logs: prepare the account manager first The log viewer assumes it's already prepared.
Created attachment 201360 [details] [review] free GDate leaks when inserting them into the model The model copies the date so we should free it afterward.
Created attachment 201361 [details] [review] fix GDate leaks when getting dates from the model
Created attachment 201362 [details] [review] don't leak uri returned by g_file_get_uri() God I hate _get functions returning new memory...
Created attachment 201363 [details] [review] fix separator leak
I fixed a bunch of leaks. Let's see how it goes with those.
+1 for all those patches.
Attachment 201358 [details] pushed as a12ee9f - empathy-logs: port to TP coding style Attachment 201359 [details] pushed as 09e6bf3 - empathy-logs: prepare the account manager first Attachment 201360 [details] pushed as 45da1ad - free GDate leaks when inserting them into the model Attachment 201361 [details] pushed as d758992 - fix GDate leaks when getting dates from the model Attachment 201362 [details] pushed as 4b81e8f - don't leak uri returned by g_file_get_uri() Attachment 201363 [details] pushed as 35b7854 - fix separator leak
Merged to 3.2 and master. Travis: Could you please retry with master or 3.2.2 and check if it's better?
(In reply to comment #10) > Merged to 3.2 and master. > > Travis: Could you please retry with master or 3.2.2 and check if it's better? I can't check this out yet due to bug #664055. I had to try reproducing it with my development user instead of my regular user since this is such a new version; I couldn't build the Debian package because its dpkg dependencies are in flux right now.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/465.