After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663873 - Massive memory leaks in Previous Conversations
Massive memory leaks in Previous Conversations
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Archives
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 663870
 
 
Reported: 2011-11-11 17:56 UTC by Travis Reitter
Modified: 2018-05-22 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
empathy-logs: port to TP coding style (1.89 KB, patch)
2011-11-14 12:23 UTC, Guillaume Desmottes
committed Details | Review
empathy-logs: prepare the account manager first (1.68 KB, patch)
2011-11-14 12:24 UTC, Guillaume Desmottes
committed Details | Review
free GDate leaks when inserting them into the model (2.37 KB, patch)
2011-11-14 12:24 UTC, Guillaume Desmottes
committed Details | Review
fix GDate leaks when getting dates from the model (1.62 KB, patch)
2011-11-14 12:24 UTC, Guillaume Desmottes
committed Details | Review
don't leak uri returned by g_file_get_uri() (1.44 KB, patch)
2011-11-14 12:24 UTC, Guillaume Desmottes
committed Details | Review
fix separator leak (759 bytes, patch)
2011-11-14 12:24 UTC, Guillaume Desmottes
committed Details | Review

Description Travis Reitter 2011-11-11 17:56:48 UTC
While writing up the various component bugs for bug #663870, my Empathy memory usage got to 4 GiB virtual memory, 2.3 GiB resident memory. It continued to grow when switching the selection in the Who/What/When columns, so a lot of memory isn't being properly freed. Opening the dialog for the first time leaks about 300 MiB (which is impressive considering my Telepathy logger files only total 128 MiB).

Furthermore, the memory isn't freed after closing the log viewer window.
Comment 1 Guillaume Desmottes 2011-11-14 12:23:59 UTC
Created attachment 201358 [details] [review]
empathy-logs: port to TP coding style
Comment 2 Guillaume Desmottes 2011-11-14 12:24:02 UTC
Created attachment 201359 [details] [review]
empathy-logs: prepare the account manager first

The log viewer assumes it's already prepared.
Comment 3 Guillaume Desmottes 2011-11-14 12:24:05 UTC
Created attachment 201360 [details] [review]
free GDate leaks when inserting them into the model

The model copies the date so we should free it afterward.
Comment 4 Guillaume Desmottes 2011-11-14 12:24:08 UTC
Created attachment 201361 [details] [review]
fix GDate leaks when getting dates from the model
Comment 5 Guillaume Desmottes 2011-11-14 12:24:11 UTC
Created attachment 201362 [details] [review]
don't leak uri returned by g_file_get_uri()

God I hate _get functions returning new memory...
Comment 6 Guillaume Desmottes 2011-11-14 12:24:14 UTC
Created attachment 201363 [details] [review]
fix separator leak
Comment 7 Guillaume Desmottes 2011-11-14 12:24:38 UTC
I fixed a bunch of leaks. Let's see how it goes with those.
Comment 8 Xavier Claessens 2011-11-14 14:28:48 UTC
+1 for all those patches.
Comment 9 Guillaume Desmottes 2011-11-14 14:38:58 UTC
Attachment 201358 [details] pushed as a12ee9f - empathy-logs: port to TP coding style
Attachment 201359 [details] pushed as 09e6bf3 - empathy-logs: prepare the account manager first
Attachment 201360 [details] pushed as 45da1ad - free GDate leaks when inserting them into the model
Attachment 201361 [details] pushed as d758992 - fix GDate leaks when getting dates from the model
Attachment 201362 [details] pushed as 4b81e8f - don't leak uri returned by g_file_get_uri()
Attachment 201363 [details] pushed as 35b7854 - fix separator leak
Comment 10 Guillaume Desmottes 2011-11-14 14:40:19 UTC
Merged to 3.2 and master.

Travis: Could you please retry with master or 3.2.2 and check if it's better?
Comment 11 Travis Reitter 2011-11-14 18:13:59 UTC
(In reply to comment #10)
> Merged to 3.2 and master.
> 
> Travis: Could you please retry with master or 3.2.2 and check if it's better?

I can't check this out yet due to bug #664055. I had to try reproducing it with my development user instead of my regular user since this is such a new version; I couldn't build the Debian package because its dpkg dependencies are in flux right now.
Comment 12 GNOME Infrastructure Team 2018-05-22 15:13:19 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/465.