After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663816 - memory corruption in gkbd-status.c
memory corruption in gkbd-status.c
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Indicator
unspecified
Other Linux
: Normal critical
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks: 663231
 
 
Reported: 2011-11-10 22:57 UTC by Christian Persch
Modified: 2011-12-05 19:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkTrayIcon:fg-color is a GdkRGBA (1.30 KB, patch)
2011-11-10 22:59 UTC, Christian Persch
none Details | Review

Description Christian Persch 2011-11-10 22:57:00 UTC
gkbd_status_render_cairo calls gdk_color_free() on a (mislabelled) GdkRGBA. This causes an nondeterministic crash in gnome-settings-daemon (at least in gnome3 fallback mode).
Comment 1 Christian Persch 2011-11-10 22:59:16 UTC
Created attachment 201198 [details] [review]
GtkTrayIcon:fg-color is a GdkRGBA

... and not a GdkColor. So use the right variable, and the right free function.
Fixes a crash on session startup in gnome-settings-daemon, when using the gnome3
fallback session.
Comment 2 Christian Persch 2011-11-21 13:40:20 UTC
Ping? Ok to commit this to master?
Comment 3 Sergey V. Udaltsov 2011-12-05 19:45:10 UTC
Pushed. Thanks!