GNOME Bugzilla – Bug 663800
Bugzilla will not CC one for comments made via git bz, even though manual comment works
Last modified: 2012-02-04 23:09:34 UTC
See: https://bugzilla.gnome.org/show_bug.cgi?id=322587 I add a comment with patch via git bz, but was not CC'd, causing me to miss the subsequent comments about my patch. I have the "Automatically add me to the CC list of bugs I change" option set to "always". I do get CC'd when commenting manually.
I assume this is a git-bz issue, not a GNOME Bugzilla one => moving.
Created attachment 206782 [details] Test attachment (attaching through attachment.cgi) Not finding the code that does the cc addition, testing if adding an attachment through attachment.cgi actually adds to the Cc: list.
Making an attachment does not add to the Cc: list - the cc: addition for a normal comment (not added with an attachment) is occurring because of the default-selected 'add me to CC list" checkbox on the bug page as far as I can tell.
Thanks for investigating. Since I have the bugzilla option "Automatically add me to the CC list of bugs I change" set to "Always", it means that bugzilla is not thinking that adding a patch is changing a bug, including the comment that gets posted when doing so. This seems wrong, and either a bug in bugzilla, or a bad phrasing (in which case fair enough, but it'd be useful to have that ability, as clearly when I post a patch I'm interested in any comments, reviews, etc, and not being able to request a CC means using git bz isn't so useful as you can miss a fair bit of feedback). So this bug can either be moved back to bugzilla, or dismissed if bugzilla people don't want to change the behavior.
Created attachment 206790 [details] [review] Add the user to the cc: on the bug All the logic to add the user to the cc: list on the bug is done in the web page for show_bug.cgi and not on the client side, so the option "Automatically add me to the CC list of bugs I change" in the user's preferences is not honored. Since that preference defaults to Always and users will very typically want to see further traffic on their patches, just always request the user to be added to the Cc. The main downside to this is that we do another round trip to the server when creating and attachment, and also potentially create more bug mail.
Created attachment 206791 [details] [review] Add the user to the cc: on the bug New version (using this bug as a testing ground)
Created attachment 206792 [details] [review] Add the user to the cc: on the bug Another new version
A test change
Created attachment 206793 [details] [review] Add the user to the cc: on the bug A hopefully working version.
Created attachment 206796 [details] [review] Add the user to the cc: on the bug Another attempt
Seems to work, pushed Attachment 206796 [details] pushed as 025fd83 - Add the user to the cc: on the bug
Thanks :)