GNOME Bugzilla – Bug 663700
[0.11] videoconvert: fix passthrough mode not being selected when possible
Last modified: 2012-01-09 12:00:06 UTC
[0.11] videoconvert: fix passthrough mode not being selected when possible Note that I'm not sure this is the best solution, but it makes the passthrough selection work. In 0.10, the structures with colorspace removed were appended to the resulting set, rather than being alone.
Created attachment 201083 [details] [review] videoconvert: fix passthrough mode not being selected when possible Colorspaces are removed from the caps, which means the one allowing passthrough is not preferred to the others. This causes downstream's first choice to be selected by default. So we now include (first) a duplicate of the hitherto first structure, without removing the format, so it will be selected if possible.
Isn't this already handled by basetransform? It really should
I went back to look at this, and it seems to select passthrough caps on the simple tests I have. Since I did not mention which pipeline I was using, I'm not sure if that's because this got fixed since, or if I'm just not hitting the same case. Anyway, either this patch is obsolete, or the wrong way to fix the issue, from what you say, so I'll just close it as invalid.