After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663700 - [0.11] videoconvert: fix passthrough mode not being selected when possible
[0.11] videoconvert: fix passthrough mode not being selected when possible
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-09 15:58 UTC by Vincent Penquerc'h
Modified: 2012-01-09 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoconvert: fix passthrough mode not being selected when possible (1.57 KB, patch)
2011-11-09 15:58 UTC, Vincent Penquerc'h 		none Details | Review

Description Vincent Penquerc'h 2011-11-09 15:58:44 UTC 
[0.11] videoconvert: fix passthrough mode not being selected when possible

Note that I'm not sure this is the best solution, but it makes the
passthrough selection work.
In 0.10, the structures with colorspace removed were appended to the
resulting set, rather than being alone.
Comment 1 Vincent Penquerc'h 2011-11-09 15:58:47 UTC 
Created attachment 201083 [details] [review]
videoconvert: fix passthrough mode not being selected when possible

Colorspaces are removed from the caps, which means the one allowing
passthrough is not preferred to the others. This causes downstream's
first choice to be selected by default.

So we now include (first) a duplicate of the hitherto first structure,
without removing the format, so it will be selected if possible.
Comment 2 Sebastian Dröge (slomo) 2011-11-24 09:46:20 UTC 
Isn't this already handled by basetransform? It really should
Comment 3 Vincent Penquerc'h 2012-01-09 12:00:06 UTC 
I went back to look at this, and it seems to select passthrough caps on the simple tests I have. Since I did not mention which pipeline I was using, I'm not sure if that's because this got fixed since, or if I'm just not hitting the same case.

Anyway, either this patch is obsolete, or the wrong way to fix the issue, from what you say, so I'll just close it as invalid.