GNOME Bugzilla – Bug 663687
Missing accessible label names on tracker-needle widgets
Last modified: 2014-12-27 16:07:55 UTC
Created attachment 201054 [details] [review] Proposed patch which adds accessible lables to radio buttons and other tracker-needle widgets. While using the Aegis accessibility tests inside the aegis accessibility test tinderbox: https://code.launchpad.net/a11ytesting I found that many of the tracker-needle widgets do not have accessible label names. You can also see these problems by running accerciser's validator plug-in. This means that certain accessibility devices such as screen readers and braille displays will not be able to display information about these widgets. I've attached a proposed patch.
Hi Brian, thank you for the patch. Are you saying there is more work needed here?
The patch is nearly complete except for 2 things: 1) I haven't been able to find where the history menu is instantiated. Atk sees it as ROLE_MENU but I don't see anything in your vala or .ui files which constructs a Gtk_menu. Looking at the patch, can you figure out where I can grab this (what appears to be a Gtk_Menu) widget and add a label to it and its menu_item children? 2) (Optional) Someone more familiar with Gtk/Atk might suggest using RELATION_LABELLED_FOR and RELATION_LABELLED_BY relationships instead of redundant labels for children of widgets.
Please hold off on applying this patch. Some of these issues may be caused by a bug in gtk3's Gtk::Builder. I'll reference that bug here as soon as I know enough to log that bug.
I am still holding ;) any ETA on this work Brian? Thanks for the patch btw. I will set this as NEEDINFO for now.
Brian, ping
Hi. Sorry about that. I'm trying to recreate the environment now. To be honest I'm not an expert on the way labels should work for comboboxes. I'll try to ask on #a11y.
Comment on attachment 201054 [details] [review] Proposed patch which adds accessible lables to radio buttons and other tracker-needle widgets. [Setting "patch" flag and correcting mime type so this can actually be queried for.]
Hm. Shall we reject the patch and close as WONTFIX?
Sorry I was pulled off of desktop. I don't have anything near the environment to be able to test this now. If no one else has reported this error, go ahead and close it as won't fix. It may have been fixed in another software layer.
No open question => resetting status
Comment on attachment 201054 [details] [review] Proposed patch which adds accessible lables to radio buttons and other tracker-needle widgets. Thanks for the patch, please go ahead and commit!
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.