After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663627 - Having a long status message makes infobar in accounts dialog uglier
Having a long status message makes infobar in accounts dialog uglier
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-08 14:12 UTC by Will Thompson
Modified: 2012-02-15 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
accounts-dialog: ellipsize presence message (1.16 KB, patch)
2012-01-06 14:10 UTC, Guillaume Desmottes 		committed Details | Review
set the presence message as a tooltip on its label (982 bytes, patch)
2012-01-06 14:10 UTC, Guillaume Desmottes 		committed Details | Review

Description Will Thompson 2011-11-08 14:12:07 UTC 
When I open the accounts dialog, my first account is selected. It's disabled, and the infobar is a bit big: <http://willthompson.co.uk/misc/weird-status-wrapping-in-account-dialog-1.png>

I have a relatively long status message set. When I select an account which is signed in, the dialog becomes enormous, as does the infobar:
<http://willthompson.co.uk/misc/weird-status-wrapping-in-account-dialog-2.png>.
Comment 1 Guillaume Desmottes 2011-11-09 15:02:45 UTC 
Could you test with master please? We did some GtkGrid porting work recently which may or may not have fixed this.
Comment 2 Akhil Laddha 2011-12-22 05:04:22 UTC 
Will, were you able to test recent changes in empathy which may address your problem ?
Comment 3 Will Thompson 2011-12-22 09:51:32 UTC 
Thanks for the reminder! The wild resizing is fixed: <http://willthompson.co.uk/misc/wrapping-fixed.png>. But the infobar still looks a bit funky compared to its appearance with a short message: <http://willthompson.co.uk/misc/short.png>. So I'm retitling.

The status icon is rammed right up against the service icon, which looks bad. (Incidentally, the new ll-xmpp icon is beautiful.) So I think there should probably be some padding there. (The same padding as between the service icon and the edge of the infobar? Relatedly, the padding between the switch and the edge of the box is totally different. <http://willthompson.co.uk/misc/measurements.png>)

We could consider just ellipsizing the status message maybe? It's not like people are in the accounts dialog for the primary purpose of checking their message.
Comment 4 Guillaume Desmottes 2012-01-06 14:09:16 UTC 
(In reply to comment #3)
> We could consider just ellipsizing the status message maybe? It's not like
> people are in the accounts dialog for the primary purpose of checking their
> message.

I agree; I've done exactly that.
Comment 5 Guillaume Desmottes 2012-01-06 14:10:00 UTC 
Created attachment 204748 [details] [review]
accounts-dialog: ellipsize presence message

Long messages make this dialog looks weird and that's not really the point of
this UI to display it anyway.
Comment 6 Guillaume Desmottes 2012-01-06 14:10:03 UTC 
Created attachment 204749 [details] [review]
set the presence message as a tooltip on its label

So user can still read the full message if it has been ellipsized.
Comment 7 Guillaume Desmottes 2012-02-15 09:23:38 UTC 
Attachment 204748 [details] pushed as be6cefc - accounts-dialog: ellipsize presence message
Attachment 204749 [details] pushed as 5fd8bf4 - set the presence message as a tooltip on its label