After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663617 - [gstffmpegdec] Don't use frame-based Multi-threading when upstream is live
[gstffmpegdec] Don't use frame-based Multi-threading when upstream is live
Status: RESOLVED DUPLICATE of bug 696501
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-08 12:53 UTC by Edward Hervey
Modified: 2013-04-05 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Edward Hervey 2011-11-08 12:53:06 UTC 
When using decoders with live streams, we shouldn't use frame-based multi-threading (FF_THREAD_FRAME) since it introduces a latency of one frame per thread.

When receiving the first buffer we should query upstream whether it is a live stream, and if it's so, set context->thread_type to FF_THREAD_SLICE only.
Comment 1 Olivier Crête 2011-11-08 15:13:41 UTC 
I'm not sure what the link is between zero latency mode and a live stream? I think its perfectly acceptable to add some latency in a live stream in some cases. The threading mode should probably be a property on the elements.
Comment 2 Edward Hervey 2011-11-10 15:14:05 UTC 
(In reply to comment #1)
> I'm not sure what the link is between zero latency mode and a live stream?

  I don't think I mentionned zero-latency (which is a codec-feature).

  Some people like having low-latency when doing real-time-communication.

  Even with a zero-latency (no B frames) stream, If you have a 6 core machines and FF_THREAD_FRAME, you'll end up adding a 6 frame-duration latency (i.e. the decoded frame will come *out* of the decoder that much later).
  With 10fps ... that's 0.6s  ... not cool.

> I think its perfectly acceptable to add some latency in a live stream in some
> cases.

  Care to expand on that ? 

> The threading mode should probably be a property on the elements.

  We could expose it, sure.
Comment 3 Tim-Philipp Müller 2013-04-05 16:36:09 UTC 
This is the same as bug #696501 really. Marking this as dup of the other one, since it's inverse now (we are now using FF_THREAD_SLICE and want to use FF_THREAD_FRAME whenever possible, for better performance).

*** This bug has been marked as a duplicate of bug 696501 ***