After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663594 - Minor whitespace parsing bug in clutter_color_from_string
Minor whitespace parsing bug in clutter_color_from_string
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-08 01:07 UTC by Craig Hughes
Modified: 2011-11-10 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix whitespace parsing issue (963 bytes, patch)
2011-11-08 01:07 UTC, Craig Hughes 		committed Details | Review

Description Craig Hughes 2011-11-08 01:07:58 UTC 
Created attachment 200948 [details] [review]
Fix whitespace parsing issue

Converting from "hsla(h,s,l,a)" had a minor bug.  If there was whitespace between the "l" value and the comma before the "a" value, parsing would fail, that is in that one spot, whitespace was not allowed though it was allowed everywhere else.  The attached patch allows whitespace in that spot to make things consistent.
Comment 1 Emmanuele Bassi (:ebassi) 2011-11-10 10:04:40 UTC 
Review of attachment 200948 [details] [review]:

looks good to me.
Comment 2 Emmanuele Bassi (:ebassi) 2011-11-10 10:05:23 UTC 
Review of attachment 200948 [details] [review]:

looks good to me.
Comment 3 Emmanuele Bassi (:ebassi) 2011-11-10 10:05:23 UTC 
Review of attachment 200948 [details] [review]:

looks good to me.
Comment 4 Emmanuele Bassi (:ebassi) 2011-11-10 10:05:56 UTC 
ugh, sorry for the comment storm - bugzilla had a fit.
Comment 5 Emmanuele Bassi (:ebassi) 2011-11-10 12:58:17 UTC 
Attachment 200948 [details] pushed to master