After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663581 - Add G_SIGNAL_DEPRECATED
Add G_SIGNAL_DEPRECATED
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-11-07 19:07 UTC by Marc-Andre Lureau
Modified: 2011-11-11 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add G_SIGNAL_DEPRECATED (5.28 KB, patch)
2011-11-07 19:07 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2011-11-07 19:07:28 UTC 
Similar to G_PARAM_DEPRECATED. It will warn only for users of the
signals, so a signal can still be emited without warning, for
compatibility reasons.

Apparently, there is no way user flags could have been used before,
so that shouldn't break anyone.
Comment 1 Marc-Andre Lureau 2011-11-07 19:07:31 UTC 
Created attachment 200913 [details] [review]
Add G_SIGNAL_DEPRECATED
Comment 2 Marc-Andre Lureau 2011-11-07 19:21:07 UTC 
just noticed bug 601686, but the patch is obsolete there, and warn on different cases (on emit, but not on override).
Comment 3 Matthias Clasen 2011-11-08 06:22:49 UTC 
Review of attachment 200913 [details] [review]:

Looks fine to me.
Comment 4 Marc-Andre Lureau 2011-11-08 10:12:18 UTC 
committed as fb95c20c96 (something went wrong with git-bz)
Comment 5 Emmanuele Bassi (:ebassi) 2011-11-11 11:49:22 UTC 
Review of attachment 200913 [details] [review]:

::: gobject/gsignal.h
@@ +136,3 @@
  * A mask for all #GSignalFlags bits.
  */
+#define G_SIGNAL_FLAGS_MASK  0x1ff

ehrm, I arrived lated, but isn't this an API break?

we went through the same thing with the GParamSpec G_PARAM_DEPRECATED flag.
Comment 6 Marc-Andre Lureau 2011-11-11 12:57:01 UTC 
Review of attachment 200913 [details] [review]:

::: gobject/gsignal.h
@@ +136,3 @@
  * A mask for all #GSignalFlags bits.
  */
+#define G_SIGNAL_FLAGS_MASK  0x1ff

there is no user defined flags in signals. And I can't see how someone could have made one since it masked out in gsignal.c.