After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663574 - gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15
gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-07 15:59 UTC by pprakash
Modified: 2013-03-09 00:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15 (1.12 KB, patch)
2011-11-07 15:59 UTC, pprakash 		reviewed Details | Review

Description pprakash 2011-11-07 15:59:40 UTC 
Created attachment 200897 [details] [review]
gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15

True RGB color format does not have any alpha components (24-bit depth), adding alpha length to depth could yield wrong results. Attached patch fixes the issue.
Comment 1 Sebastian Dröge (slomo) 2011-11-08 12:17:15 UTC 
Shouldn't the alpha channel length be 0 for non-alpha formats and give the correct results?
Comment 2 Akhil Laddha 2011-12-22 05:02:00 UTC 
pprakash, can you please respond to comment#1 ?
Comment 3 pprakash 2011-12-22 14:24:30 UTC 
Sorry for the delay, I seem to have missed this response. I agree that channel length for non-alpha format should be 0. I have implemented  the required changes in the kernel driver to reflect this. However, the default caps configuration for gstfbdevsink is for RGB 15 and there is no alpha component for this data format.
Comment 4 André Klapper 2012-02-02 21:13:03 UTC 
Comment on attachment 200897 [details] [review]
gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15

[Setting "patch" flag and correcting mime type so this can actually be queried for.]
Comment 5 Tim-Philipp Müller 2013-03-09 00:24:12 UTC 
Sorry for letting this patch sit in bugzilla for such a long time. I've now ported fbdevsink to GStreamer 1.0 and think the issue is addressed there. Would be grateful if you could test it (since I've only tested RGBx).