After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663567 - Status icon is miss aligned in infobar
Status icon is miss aligned in infobar
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-07 15:16 UTC by Guillaume Desmottes
Modified: 2011-11-09 01:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (6.81 KB, image/jpeg)
2011-11-07 15:16 UTC, Guillaume Desmottes 		  Details
accounts-dialog: fix box packing issue in infobar (2.78 KB, patch)
2011-11-07 22:51 UTC, Danielle Madeley 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2011-11-07 15:16:38 UTC 
Created attachment 200889 [details]
screenshot

Looks like http://git.gnome.org/browse/empathy/commit/?id=1cd6e8253a3be284b8578fd9ea37016d0197d61b broke alignement of the status icon. It should be next to the state label.
Comment 1 Danielle Madeley 2011-11-07 22:51:37 UTC 
Created attachment 200937 [details] [review]
accounts-dialog: fix box packing issue in infobar

Expanding the status causes the icon to be placed on the far left of the box.
This regression caused by my work in 1cd6e8253a3be284b8578fd9ea37016d0197d61b.
Need an additional hbox and to expand that.

Fixes:
Comment 2 Guillaume Desmottes 2011-11-08 09:00:50 UTC 
Review of attachment 200937 [details] [review]:

++; both branches (iirc you merged your first commit to 3.2 too right?)
Comment 3 Danielle Madeley 2011-11-09 01:22:14 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.