After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663527 - Up/Down buttons for mail account sort order greyed out; option to enable them not obvious
Up/Down buttons for mail account sort order greyed out; option to enable them...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.4.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 663837 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-11-06 22:34 UTC by André Klapper
Modified: 2013-09-13 01:06 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4



Description André Klapper 2011-11-06 22:34:24 UTC
Evo 3.3.2 from git master.

I tried to change the order of the accounts listed under
  Edit > Preferences > Mail Accounts.
The buttons always remained greyed out.

After a while I discovered the checkbox "Use default Evolution _sort order for accounts" at the bottom. This didn't look connected at all to me.

Maybe hide the two disabled buttons on the right, and only display them when the checkbox gets/is enabled?
Comment 1 Matthew Barnes 2011-11-07 00:40:38 UTC
I don't think we need the checkbox at all.

Also, the accounts should be reorderable via drag-and-drop.  I'd almost say remove the Up and Down buttons too.
Comment 2 Milan Crha 2011-11-10 16:48:58 UTC
The check is for backward compatibility, and I consider it useful, personally. Hiding them might work for me, though HIG is probably against it. What about putting the check at the top? Not that it'll help always, but should be slightly better, I hope.

(Give me a green, and I'll do it.)
Comment 3 Matthew Barnes 2011-11-10 17:44:29 UTC
What I had in mind is a blue info bar and the bottom of the accounts list:

   -------------------------------------------------------------------------
   You can drag and drop account names to reorder them.    [Restore Default]
   -------------------------------------------------------------------------

Instead of having an ON/OFF state for the account ordering, which is kinda confusing, just have a regular button that puts the accounts back in their default order.

I think you'd just need to call gtk_tree_View_set_reorderable() and then listen for GtkTreeModel::rows-reordered signals to save the state.
Comment 4 André Klapper 2011-11-10 23:39:50 UTC
(In reply to comment #3)
>    You can drag and drop account names to reorder them.    [Restore Default]

Will [Restore Default] be greyed out/disabled if it currently actually is the default stage? 
I'm torn between "Why does it do nothing when I click it" bug reports in case it's always enabled, and "Why is it greyed out? I want the default back" bug reports if it's disabled when the order is the default anyway. ;-)
Comment 5 Matthew Barnes 2011-11-11 00:51:43 UTC
*shrug*  I guess it could be but I don't think it's critical.
Comment 6 Matthew Barnes 2011-11-11 13:12:40 UTC
*** Bug 663837 has been marked as a duplicate of this bug. ***
Comment 7 Akhil Laddha 2011-11-18 06:50:12 UTC
(In reply to comment #1)
> Also, the accounts should be reorderable via drag-and-drop.  I'd almost say
> remove the Up and Down buttons too.

This can be done as part of bug 651270
Comment 8 Matthew Barnes 2011-12-11 02:52:09 UTC
Fixed for Evolution 3.3.3 as part of:
http://git.gnome.org/browse/evolution/commit/?id=7c0c40f83317228e0a725bfb5ca8854339d25588