After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663499 - gstreamer-0.10: Fix ElementList related functions
gstreamer-0.10: Fix ElementList related functions
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 663497
 
 
Reported: 2011-11-06 12:58 UTC by Jens Georg
Modified: 2011-11-07 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstreamer-0.10: Fix ElementList related functions (3.64 KB, patch)
2011-11-06 12:58 UTC, Jens Georg 		none Details | Review

Description Jens Georg 2011-11-06 12:58:05 UTC 
Fix return type ownership and element type for ElementFactory
functions dealing with lists.
Comment 1 Jens Georg 2011-11-06 12:58:27 UTC 
Created attachment 200828 [details] [review]
gstreamer-0.10: Fix ElementList related functions

Set proper return type and ownership for ElementFactory.list_filter
and ElementFactory.list_get_elements as well as making
ElementListFactoryType inherit from int64.
Comment 2 Luca Bruno 2011-11-06 18:11:18 UTC 
Thanks for the patch. Are you sure that <ElementListType> is right instead of <ElementTypeListType?> ? Did you test that? Using an int64 as generic is unsafe.
Comment 3 Jens Georg 2011-11-07 07:31:39 UTC 
I think you misread the patch, the generic is always ElementFactory, ElementFactoryListType is the first parameter of ElementFactory.list_get_elements
Comment 4 Luca Bruno 2011-11-07 09:45:54 UTC 
commit 093fc8f9a0351201e403c83f86579d86d50c19a5
Author: Jens Georg <mail@jensge.org>
Date:   Sun Nov 6 13:51:50 2011 +0100

    gstreamer-0.10: Fix ElementFactory methods and ElementFactoryListType
    
    Set proper return type and ownership for ElementFactory.list_filter
    and ElementFactory.list_get_elements as well as making
    ElementFactoryListType inherit from int64.
    
    Fixes bug 663499.

I've changed the ListType to be an uint64.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.