After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663469 - Python plugins are not internationalized
Python plugins are not internationalized
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-05 20:29 UTC by Piotr Drąg
Modified: 2011-11-07 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing the problem (10.64 KB, patch)
2011-11-05 21:13 UTC, Piotr Drąg 		none Details | Review
Fixed patch (9.88 KB, patch)
2011-11-06 01:15 UTC, Piotr Drąg 		none Details | Review

Description Piotr Drąg 2011-11-05 20:29:41 UTC 
Every plugin written in Python (I tested artdisplay, context, im-status, lyrics, python-console, sendto) is not internationalized in the UI.
Comment 1 Piotr Drąg 2011-11-05 20:45:58 UTC 
I discovered that .py files are missing "import gettext" headers. I think adding them would fix the issue.
Comment 2 Piotr Drąg 2011-11-05 21:13:41 UTC 
Created attachment 200788 [details] [review]
Patch fixing the problem

This patch fixes the issue in my (very limited) testing.
Comment 3 Jonathan Matthew 2011-11-06 00:56:16 UTC 
We should do something like this instead:

import gettext
gettext.install('rhythmbox', localedir)

since that's what we used to do for python plugins automatically.
Comment 4 Piotr Drąg 2011-11-06 01:15:13 UTC 
Created attachment 200805 [details] [review]
Fixed patch

Ok, so here is second version of the patch.
Comment 5 Piotr Drąg 2011-11-06 20:52:10 UTC 
The second one doesn't work. I'm not a programmer, so this is it for me. I hope you could fix it properly.
Comment 6 Jonathan Matthew 2011-11-07 11:46:37 UTC 
Sorry, I should have explained that there wasn't a way to get the value for 'localedir' previously.  I just added a function to do that, then fixed up your patch to use it and pushed as commit 7021991.  Thanks for helping out with this.