Created attachment 200763 [details] [review]
StTextureCache: Obey cache policy in st_texture_cache_load

Created attachment 200764 [details] [review]
StThemeNode: Fix a GCC warning

Review of attachment 200763 [details] [review]:

::: src/st/st-texture-cache.c
@@ +976,3 @@
     }
+
+  return cogl_handle_ref (texture);

- calls cogl_handle_ref() on null in the case of error
- leaks the texture when policy is not FOREVER by ref'ing it when it shouldn't

Review of attachment 200764 [details] [review]:

Commit message should give some idea of what gcc warning is being fixed, and maybe for what gcc version - is this with our default compiler flags (I don't see a warning and we don't include -Wshadow by default)? Patch itself looks OK as a cleanup

Created attachment 207593 [details] [review]
st-texture-cache: Obey cache policy in st_texture_cache_load

Ah, I see.

Created attachment 207594 [details] [review]
st-theme-node: Fix an accidental shadow

This may cause a gcc warning, nothing serious.



Huh. I'm not hitting the warning anymore... I was at one time, I swear.
Oh well, the shadow cleanup is still worthwhile IMO.

Created attachment 207595 [details] [review]
st-texture-cache: Obey cache policy in st_texture_cache_load

Wait, no, that's wrong. This should be correct.

Comment on attachment 207594 [details] [review]
st-theme-node: Fix an accidental shadow

Attachment 207594 [details] was obsoleted by commit a025b151ef.

Attachment 207595 [details] pushed as 50e849a - st-texture-cache: Obey cache policy in st_texture_cache_load