After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663444 - api thats stuck in core-pointer land
api thats stuck in core-pointer land
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GdkDevice
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Carlos Garnacho
Depends on:
Blocks:
 
 
Reported: 2011-11-05 04:23 UTC by Matthias Clasen
Modified: 2011-11-05 05:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkWindow: Use new begin_resize_drag api (1.61 KB, patch)
2011-11-05 05:14 UTC, Matthias Clasen 		committed Details | Review
Wayland: Adapt to GdkWindowImpl api change (2.33 KB, patch)
2011-11-05 05:14 UTC, Matthias Clasen 		committed Details | Review
Broadway: Adapt to GdkWindowImpl API change (1.14 KB, patch)
2011-11-05 05:14 UTC, Matthias Clasen 		committed Details | Review
Quartz: Adapt to GdkWindowImpl api change (1.29 KB, patch)
2011-11-05 05:15 UTC, Matthias Clasen 		committed Details | Review
win32: Adapt to GdkWindowImpl api change (1.22 KB, patch)
2011-11-05 05:15 UTC, Matthias Clasen 		committed Details | Review
Add device-taking variants of begin_resize/move_drag (16.40 KB, patch)
2011-11-05 05:15 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2011-11-05 04:23:32 UTC 
gdk_window_begin_resize_drag
gdk_window_begin_move_drag
gtk_window_begin_resize_drag
gtk_window_begin_move_drag

These currently just take button+position+timestamp from an event, and then gdk goes and takes a grab on core_pointer.
We need variants that take a device.
Comment 1 Matthias Clasen 2011-11-05 05:14:49 UTC 
The following fixes have been pushed:
7644ef1 GtkWindow: Use new begin_resize_drag api
3b152df Wayland: Adapt to GdkWindowImpl api change
810ef68 Broadway: Adapt to GdkWindowImpl API change
6f48f20 Quartz: Adapt to GdkWindowImpl api change
32884e9 win32: Adapt to GdkWindowImpl api change
250d433 Add device-taking variants of begin_resize/move_drag
Comment 2 Matthias Clasen 2011-11-05 05:14:51 UTC 
Created attachment 200730 [details] [review]
GtkWindow: Use new begin_resize_drag api

We have an event, so the correct thing to do is to pass
the device into the function that we are calling. GDK
just grew a variant that takes a device, for this purpose.
Comment 3 Matthias Clasen 2011-11-05 05:14:55 UTC 
Created attachment 200731 [details] [review]
Wayland: Adapt to GdkWindowImpl api change
Comment 4 Matthias Clasen 2011-11-05 05:14:58 UTC 
Created attachment 200732 [details] [review]
Broadway: Adapt to GdkWindowImpl API change
Comment 5 Matthias Clasen 2011-11-05 05:15:00 UTC 
Created attachment 200733 [details] [review]
Quartz: Adapt to GdkWindowImpl api change
Comment 6 Matthias Clasen 2011-11-05 05:15:07 UTC 
Created attachment 200734 [details] [review]
win32: Adapt to GdkWindowImpl api change
Comment 7 Matthias Clasen 2011-11-05 05:15:10 UTC 
Created attachment 200735 [details] [review]
Add device-taking variants of begin_resize/move_drag

This was one of the last places where display->core_pointer was
used in non-deprecated code paths.