After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663440 - CD does not resume playing after pausing
CD does not resume playing after pausing
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
unspecified
Other Linux
: Normal critical
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 688264 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-11-05 02:46 UTC by tkhan4486
Modified: 2012-11-14 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cleanup the 'open location' thread (370 bytes, patch)
2012-10-25 04:43 UTC, Yu Ning
none Details | Review

Description tkhan4486 2011-11-05 02:46:05 UTC
I am currently running version 2.90.1 in Fedora 15. There's a problem where when I press the "play" button after pausing playback of a CD, playback doesn't resume. The button is pressed, but the CD remains paused. The only way around this is to eject the CD, reinsert it and play from where I want it to.
Comment 1 Fabio Sasso 2012-03-03 09:42:40 UTC
please investigate with this terrible bug!
Comment 2 Vadim Rutkovsky 2012-03-15 12:38:40 UTC
Reproduced in Ubuntu 12.04 rhythmbox 2.95-5ubuntu1 (bug https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/954951)

Debug log: https://launchpadlibrarian.net/96778606/rhythmbox-debug.txt
Comment 3 melchiaros 2012-06-23 10:28:03 UTC
This is limited to only .wav files. CD with .mp3 works properly.
Comment 4 Yu Ning 2012-10-25 04:43:40 UTC
Created attachment 227220 [details] [review]
cleanup the 'open location' thread

This issue is due to the incomplete cleanup in the 'open location' thread, which will lead to a checking always failed when resumed or another track played.

My patch may fix this issue, and it works for me.
Comment 5 Jonathan Matthew 2012-10-28 04:05:16 UTC
Thanks for the patch, but this isn't quite the right fix. The playlist parser thread isn't supposed to refer to the main thread's cancellable, because the user might have started playing something else by the time it runs. Instead, the shell player should have been clearing its pointer to the cancellable when pausing playback. I've made this change in commit 98e5a25.
Comment 6 Fabio Sasso 2012-10-28 09:46:53 UTC
this means that with the next version of rhythmbox we can pause CD playing with no problems?
Comment 7 Jonathan Matthew 2012-11-14 10:00:12 UTC
*** Bug 688264 has been marked as a duplicate of this bug. ***
Comment 8 Paul Menzel 2012-11-14 10:08:16 UTC
The following commit fixes this [1].

commit 98e5a25b3c32c9915357968a78783c1ac21c7130
Author: Jonathan Matthew <jonathan@d14n.org>
Date:   Sun Oct 28 14:02:53 2012 +1000

    shell-player: clear playlist parser cancellable when pausing

    https://bugzilla.gnome.org/show_bug.cgi?id=663440

[1] http://git.gnome.org/browse/rhythmbox/commit/?id=98e5a25b3c32c9915357968a78783c1ac21c7130