After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663431 - keyboard: Remove support for conditional shortcuts
keyboard: Remove support for conditional shortcuts
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 670847 (view as bug list)
Depends on: 621204 635378
Blocks:
 
 
Reported: 2011-11-04 20:14 UTC by Florian Müllner
Modified: 2012-02-26 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Remove support for conditional shortcuts (6.24 KB, patch)
2011-11-04 20:15 UTC, Florian Müllner 		committed Details | Review
keyboard: Stop monitoring num-workspaces (2.89 KB, patch)
2011-11-11 01:06 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-11-04 20:14:45 UTC 
See patch.
Comment 1 Florian Müllner 2011-11-04 20:15:04 UTC 
Created attachment 200713 [details] [review]
keyboard: Remove support for conditional shortcuts

Keyboard shortcut definitions could specify a condition to determine
whether it should be shown in the UI or not. This was only used by
Metacity/Mutter, to make the visibility of some shortcuts depend on
the number of workspaces. However, as workspaces are now managed
dynamically in GNOME 3, the frequent changes to the list of shortcuts
have become rather confusing, so a fixed list of shortcuts is used now.

With the only consumer of conditional shortcuts gone, there's no reason
to keep the feature around.
Comment 2 Bastien Nocera 2011-11-04 22:09:52 UTC 
Review of attachment 200713 [details] [review]:

Looks good.
Comment 3 Florian Müllner 2011-11-11 01:06:42 UTC 
Created attachment 201201 [details] [review]
keyboard: Stop monitoring num-workspaces

Metacity/Mutter no longer have conditional shortcuts depending on
the number of workspaces, so there is no need to monitor the
num-workspaces settings (and reload all keybindings).

Related follow-up patch.
Comment 4 Florian Müllner 2011-11-11 19:37:42 UTC 
Comment on attachment 200713 [details] [review]
keyboard: Remove support for conditional shortcuts

Attachment 200713 [details] pushed as be4e40b - keyboard: Remove support for conditional shortcuts
Comment 5 Bastien Nocera 2011-11-14 10:12:20 UTC 
Attachment 201201 [details] pushed as 246a44c - keyboard: Stop monitoring num-workspaces
Comment 6 Bastien Nocera 2012-02-26 21:06:43 UTC 
*** Bug 670847 has been marked as a duplicate of this bug. ***