After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663429 - Adapt to mutter moving to GSettings
Adapt to mutter moving to GSettings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 635378
Blocks:
 
 
Reported: 2011-11-04 19:05 UTC by Florian Müllner
Modified: 2011-11-15 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adapt to mutter moving to GSettings (19.70 KB, patch)
2011-11-04 19:05 UTC, Florian Müllner 		accepted-commit_now Details | Review
Adapt to mutter moving to GSettings (21.22 KB, patch)
2011-11-11 18:18 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-11-04 19:05:41 UTC 
See patch.
Comment 1 Florian Müllner 2011-11-04 19:05:47 UTC 
Created attachment 200709 [details] [review]
Adapt to mutter moving to GSettings
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-11-05 16:46:17 UTC 
Review of attachment 200709 [details] [review]:

Sure.

::: js/ui/main.js
@@ +586,3 @@
     // modal dialog is present)
     if (action == Meta.KeyBindingAction.COMMAND_SCREENSHOT) {
+        let settings = new Gio.Settings({ schema: 'org.gnome.desktop.wm.keybinding-commands' });

Perhaps the schema should go at the top?
Comment 3 Florian Müllner 2011-11-11 18:18:09 UTC 
Created attachment 201249 [details] [review]
Adapt to mutter moving to GSettings

A couple of updates due to schema changes.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-11-11 19:33:43 UTC 
Review of attachment 201249 [details] [review]:

Looks good.
Comment 5 Florian Müllner 2011-11-15 12:45:42 UTC 
Attachment 201249 [details] pushed as a9ab878 - Adapt to mutter moving to GSettings

Oops, the patch was pushed, but somehow git-bz failed to update the bug ...