GNOME Bugzilla – Bug 663398
Native Window Placement improvement: icon overlay
Last modified: 2013-12-24 13:07:07 UTC
Sometime different windows seems equal at first look (e.g. browser with empty page, terminal, document, etc). I think that adding over the window the application icon will improve the usability. I've seen this capability in compiz and in kde. Thanks. Donato
I started hacking this a bit to add icons, working off of the Overlay Icons extension (https://extensions.gnome.org/extension/60/overlay-icons/). The code is rather ugly at the moment. Notably: - It will only work when the title is at the top, since I just attached code to the existing framework. - There are several different injection methods sitting around. If you're interested in including this in the extension, let me know and I'll start cleaning things up.
Created attachment 216715 [details] [review] Patch to remove tabs This doesn't actually have anything to do with this bug, but my OCD didn't let me start until this was fixed.
Created attachment 216716 [details] [review] Patch to add icons to overlay This patch has most of the changes. It's rather ugly, in large part because I don't know when we can overwrite the existing functions, and when we have to carefully inject our code. All the injections are done "by hand", which made sense when I was adding the first function from Overlay Icons. By the fifth, it was a stupid decision.
Created attachment 216717 [details] [review] Patch to change injection method I realized that, since we were attaching these functions to the relevant signals, we didn't have to inject -- we could just attach a separate function that would call the original. But for reasons I don't understand, this doesn't work with the show and hide functions.
Hi there, I'm going to close this bug as there was a previous bug report about such report with code and it was rejected, and such functionnality goes into an extension. Regards.