After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663350 - theoraenc: do not reset the encoder when we need a keyframe
theoraenc: do not reset the encoder when we need a keyframe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-03 20:01 UTC by Vincent Penquerc'h
Modified: 2013-03-31 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theoraenc: do not reset the encoder when we need a keyframe (4.10 KB, patch)
2011-11-03 20:01 UTC, Vincent Penquerc'h 		accepted-commit_now Details | Review
theoraenc: do not reset the encoder when we need a keyframe (2.53 KB, patch)
2013-02-25 10:54 UTC, Tim-Philipp Müller 		committed Details | Review

Description Vincent Penquerc'h 2011-11-03 20:01:03 UTC 
theoraenc: do not reset the encoder when we need a keyframe
Comment 1 Vincent Penquerc'h 2011-11-03 20:01:05 UTC 
Created attachment 200643 [details] [review]
theoraenc: do not reset the encoder when we need a keyframe

Instead, remember we need a keyframe, and we will force the encoder
to emit one next time we submit a new frame.
Since libtheora does not have an API to request a keyframe, we reset
the max keyframe interval to 1 temporarily.
Comment 2 Olivier Crête 2011-11-03 20:13:28 UTC 
What improvements do we get from not resetting the encoder ?
Comment 3 Vincent Penquerc'h 2011-11-03 20:46:08 UTC 
The rate control keeps its history.
A wee bit faster, I suppose.
We don't risk the encoder choosing different quant tables (not that it does in practice I think).
A fuzzy feeling of doing it correctly.
Comment 4 Olivier Crête 2013-01-21 19:35:21 UTC 
Comment on attachment 200643 [details] [review]
theoraenc: do not reset the encoder when we need a keyframe

You had me at rate control, please port to the newer code and commit!
Comment 5 Tim-Philipp Müller 2013-02-25 10:54:06 UTC 
Created attachment 237345 [details] [review]
theoraenc: do not reset the encoder when we need a keyframe

Updated to git master. Untested so far. Someone please test it.
Comment 6 Tim-Philipp Müller 2013-03-31 14:49:50 UTC 
Comment on attachment 237345 [details] [review]
theoraenc: do not reset the encoder when we need a keyframe

Pushed this, fingers crossed ;)