GNOME Bugzilla – Bug 663338
[PATCH] typo in messages
Last modified: 2011-11-03 18:08:41 UTC
There are typo "XMDCP" which should be "XDMCP". patch follows: diff --git a/daemon/gdm-xdmcp-display-factory.c b/daemon/gdm-xdmcp-display-factory.c index d5ac32b..37f97e4 100644 --- a/daemon/gdm-xdmcp-display-factory.c +++ b/daemon/gdm-xdmcp-display-factory.c @@ -2905,13 +2905,13 @@ decode_packet (GIOChannel *source, if G_UNLIKELY (header.version != XDM_PROTOCOL_VERSION && header.version != GDM_XDMCP_PROTOCOL_VERSION) { - g_warning (_("XMDCP: Incorrect XDMCP version!")); + g_warning (_("XDMCP: Incorrect XDMCP version!")); return TRUE; } address = gdm_address_new_from_sockaddr ((struct sockaddr *) &clnt_ss, ss_len); if (address == NULL) { - g_warning (_("XMDCP: Unable to parse address")); + g_warning (_("XDMCP: Unable to parse address")); return TRUE; } diff --git a/gui/simple-chooser/gdm-host-chooser-widget.c b/gui/simple-chooser/gdm-host-chooser-widget.c index 3e8a2e2..a1b2751 100644 --- a/gui/simple-chooser/gdm-host-chooser-widget.c +++ b/gui/simple-chooser/gdm-host-chooser-widget.c @@ -224,13 +224,13 @@ decode_packet (GIOChannel *source, if G_UNLIKELY (header.version != XDM_PROTOCOL_VERSION && header.version != GDM_XDMCP_PROTOCOL_VERSION) { - g_warning (_("XMDCP: Incorrect XDMCP version!")); + g_warning (_("XDMCP: Incorrect XDMCP version!")); return TRUE; } address = gdm_address_new_from_sockaddr ((struct sockaddr *) &clnt_ss, ss_len); if (address == NULL) { - g_warning (_("XMDCP: Unable to parse address")); + g_warning (_("XDMCP: Unable to parse address")); return TRUE; }
warnings should probably in english so they're googable
The following fixes have been pushed: df50577 daemon: correct XDMCP misspelling 7c4b7c1 daemon: remove translation markers from xdmcp warnings
Created attachment 200632 [details] [review] daemon: correct XDMCP misspelling It's spelled XDMCP not XMDCP
Created attachment 200633 [details] [review] daemon: remove translation markers from xdmcp warnings They're warnings the user won't see without snooping. They are hardly intelligible as it is and shouldn't be translated, so they're easy to google.