After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663333 - basetransfrom cache should be invalidated whenever there is any change in the peer caps
basetransfrom cache should be invalidated whenever there is any change in the...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-03 15:45 UTC by Sjoerd Simons
Modified: 2011-11-07 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add API to check if caps are exactly the same (better fucntion name might be good) (2.23 KB, patch)
2011-11-03 15:46 UTC, Sjoerd Simons 		none Details | Review
Only use the cached version if the peer caps stayed exactly the same (976 bytes, patch)
2011-11-03 15:46 UTC, Sjoerd Simons 		none Details | Review

Description Sjoerd Simons 2011-11-03 15:45:14 UTC 
gst_caps_is_equal simply checks of both cap sets represent the same global set of capabilities, so it doesn't take into account any specific ordering information, to be more precise, the following caps are equal:

video/x-raw-yuv, width=640 ; video/x-raw-yuv, width=[1..MAX] and
video/x-raw-yuv, width=320; video/x-raw-yuv, with=[1..MAX]

Not flushing the cache can cause an upstream element to stay with the old resolution instead of moving to the new one if switching between these caps after a basetransform.
Comment 1 Sjoerd Simons 2011-11-03 15:46:01 UTC 
Created attachment 200608 [details] [review]
Add API to check if caps are exactly the same (better fucntion name might be good)
Comment 2 Sjoerd Simons 2011-11-03 15:46:39 UTC 
Created attachment 200609 [details] [review]
Only use the cached version if the peer caps stayed exactly the same
Comment 3 Sjoerd Simons 2011-11-04 18:25:32 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.