Created attachment 200561 [details] [review]
Don't call g_thread_init()

The following fix has been pushed:
f5c1a48 Don't call g_thread_init()

Created attachment 200592 [details] [review]
Don't call g_thread_init()

g_type_init() has been doing this anyway since GLib 2.24 or so
anyway. And with GLib 2.31, it is not necessary anymore.

The previous patch only fixed one instance, but current git head has a few more places, which causes build failure now.

Created attachment 204493 [details] [review]
Fix remaining g_thread_init calls

This fixes the remaining instances. OK for me to push?

Comment on attachment 200561 [details] [review]
Don't call g_thread_init()

duplicate patch attachment, marking as committed/obsolete for clarity

Review of attachment 204493 [details] [review]:

::: tests/test-location-entry.c
@@ +221,3 @@
   GtkTreeIter iter;
 
+  g_type_init ();

This can just go away altogether, gtk_init already takes care of it.

::: tests/test-settings.c
@@ +208,3 @@
     gint i;
 
+    g_type_init ();

same here

::: tests/test-view.c
@@ +69,3 @@
     GCancellable *cancellable;
 
+    g_type_init ();

and here

Created attachment 204583 [details] [review]
Fix remaining g_thread_init calls

Ah, right. Updated patch attached.

Thanks!

Pushed to master. Thanks.