After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663278 - pos is undefined
pos is undefined
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-03 00:05 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-11-06 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NetworkMenu: fix regression in access-point-removed (1.06 KB, patch)
2011-11-03 09:04 UTC, Giovanni Campagna 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-11-03 00:05:02 UTC 
JS ERROR: !!!   Exception was: ReferenceError: pos is not defined
    JS ERROR: !!!     lineNumber = '1324'
    JS ERROR: !!!     fileName = '"/home/jstpierre/Source/gnome3/install/share/gnome-shell/js/ui/status/network.js"'
    JS ERROR: !!!     stack = '"([object _private_NMClient_DeviceWifi],[object _private_NMClient_AccessPoint])@/home/jstpierre/Source/gnome3/install/share/gnome-shell/js/ui/status/network.js:1324
"'
    JS ERROR: !!!     message = '"pos is not defined"'
Comment 1 Giovanni Campagna 2011-11-03 09:04:15 UTC 
Created attachment 200574 [details] [review]
NetworkMenu: fix regression in access-point-removed

When changing _findNetwork with _findExistingNetwork, I changed
the return value to avoid searching twice for the access point,
and changed some names. Except that I forgot to update all points
wehre those names were used.
Comment 2 Rui Matos 2011-11-03 16:52:25 UTC 
Review of attachment 200574 [details] [review]:

Fixes the bug. Looks good.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-11-03 19:51:54 UTC 
"wehre" in the commit message, and don't start a sentence with "Except":

    ... and changed some names. I forgot to update all the places
    where those names were used.
Comment 4 Allison Karlitskaya (desrt) 2011-11-06 19:35:16 UTC 
Introduced by the fix for bug 651378, it seems.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-11-06 21:55:47 UTC 
Attachment 200574 [details] pushed as 43f53a7 - NetworkMenu: fix regression in access-point-removed


--

Pushed for Giovanni.