Bug 663256 – Accessibility menu does not have "screen reader"

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 663256 - Accessibility menu does not have "screen reader"


Summary:	Accessibility menu does not have "screen reader"


Status:	RESOLVED FIXED

Product:	gnome-shell
Classification:	Core
Component:	general
Version:	3.2.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gnome-shell-maint
QA Contact:	gnome-shell-maint

URL:
Whiteboard:

Depends on:	678187
Blocks:

Reported:	2011-11-02 18:13 UTC by Hubert Figuiere (:hub)
Modified:	2012-06-19 16:20 UTC

See Also:
GNOME target:	3.6
GNOME version:	3.1/3.2

Attachments
Screenshot of the menu (113.86 KB, image/png) 2011-11-02 18:14 UTC, Hubert Figuiere (:hub)		Details
trivial patch (1.25 KB, patch) 2012-06-15 21:53 UTC, Matthias Clasen	accepted-commit_now	Details \| Review

Description Hubert Figuiere (:hub) 2011-11-02 18:13:52 UTC

The Accessibility menu does not have the screen reader listed, so the user can't enable it from the menu and has to go to system settings.

See screenshots

Comment 1 Hubert Figuiere (:hub) 2011-11-02 18:14:18 UTC

Created attachment 200531 [details]
Screenshot of the menu

Comment 2 Matthias Clasen 2011-11-07 12:27:52 UTC

It is not there, because it has not been reliable enough.
That is still the case. When an AT like orca is running, applications tend to crash when interacting with any treeview, such as in the file chooser...

Comment 3 Hubert Figuiere (:hub) 2011-11-08 00:57:31 UTC

Indeed. I hadn't realized at the time Gnome-shell crashed as it was restarting without disruption. But it seems that Emacs is crashing too. Etc. :-(

Comment 4 Matthias Clasen 2012-03-27 00:58:15 UTC

I think we should reevaluate this for 3.6, things are better now

Comment 5 Matthias Clasen 2012-05-07 13:03:23 UTC

if we push for a11y on-by-default in 3.6, we should get this done

Comment 6 Matthias Clasen 2012-06-15 21:53:40 UTC

Created attachment 216542 [details] [review]
trivial patch

Comment 7 Matthias Clasen 2012-06-15 21:54:44 UTC

Unfortunately, with this patch, turning the screen reader off again from the menu triggers a segfault in cally:

+ Trace 230374

#0 ??
#1 notify_hf
at cally/cally-util.c line 459
#2 g_hash_table_foreach_remove_or_steal
at ghash.c line 1408
#3 g_hash_table_foreach_steal
at ghash.c line 1481
#4 cally_key_snooper
at cally/cally-util.c line 490
#5 cally_key_snooper
at cally/cally-util.c line 470
#6 _clutter_marshal_BOOLEAN__BOXED
at clutter-marshal.c line 85
#7 g_closure_invoke
at gclosure.c line 777
#8 signal_emit_unlocked_R
at gsignal.c line 3547
#9 g_signal_emit_valist
at gsignal.c line 3306
#10 g_signal_emit
at gsignal.c line 3352
#11 clutter_actor_event
at ./clutter-actor.c line 12409
#12 emit_event
at ./clutter-main.c line 2268
#13 emit_keyboard_event
at ./clutter-main.c line 2326
#14 _clutter_process_event_details
at ./clutter-main.c line 2426
#15 _clutter_process_event
at ./clutter-main.c line 2692
#16 _clutter_stage_process_queued_events
at ./clutter-stage.c line 1023
#17 master_clock_process_events
at ./clutter-master-clock.c line 283
#18 clutter_clock_dispatch
at ./clutter-master-clock.c line 513
#19 g_main_dispatch
at gmain.c line 2539
#20 g_main_context_dispatch
at gmain.c line 3075
#21 g_main_context_iterate
at gmain.c line 3146
#22 g_main_loop_run
at gmain.c line 3340
#23 meta_run
at core/main.c line 548
#24 main
at main.c line 396

Comment 8 Florian Müllner 2012-06-15 21:55:49 UTC

Review of attachment 216542 [details] [review]:

Sure.

Comment 9 Florian Müllner 2012-06-15 22:00:00 UTC

Review of attachment 216542 [details] [review]:

(In reply to comment #7)
> Unfortunately, with this patch, turning the screen reader off again from the
> menu triggers a segfault

Whoops, obviously not a-c-n then

Comment 10 Matthias Clasen 2012-06-19 10:45:52 UTC

fixed with clutter master

Comment 11 Florian Müllner 2012-06-19 11:21:33 UTC

Review of attachment 216542 [details] [review]:

Go ahead then