GNOME Bugzilla – Bug 663174
oggmux: set collectpads2 not to wait on sparse streams
Last modified: 2011-11-25 16:24:42 UTC
Created attachment 200411 [details] [review] oggmux: set collectpads2 not to wait on sparse streams
Comment on attachment 200411 [details] [review] oggmux: set collectpads2 not to wait on sparse streams Argh. This causes trouble with headers written later than they should.
Created attachment 200423 [details] [review] oggmux: set collectpads2 not to wait on sparse streams
Review of attachment 200423 [details] [review]: ::: ext/ogg/gstoggmux.c @@ +467,3 @@ oggpad = (GstOggPadData *) gst_collect_pads2_add_pad_full (ogg_mux->collect, newpad, + sizeof (GstOggPadData), gst_ogg_mux_ogg_pad_destroy_notify, FALSE); Are you sure this shouldn't be left as TRUE @@ +993,3 @@ + GST_DEBUG_OBJECT (pad, "Pad is sparse, marking as such"); + gst_collect_pads2_set_waiting (ogg_mux->collect, + (GstCollectData2 *) pad, FALSE); ...and only changed here for sparse streams?
That first boolean is "lock the state", which means it cannot be set to FALSE to sparse streams later if "lock the state" is TRUE.
Comment on attachment 200423 [details] [review] oggmux: set collectpads2 not to wait on sparse streams Oops, right. Please push this :)
commit c6b9145630373f82cb82040bf54c0189bab416db Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Tue Nov 1 15:21:54 2011 +0000 oggmux: set collectpads2 not to wait on sparse streams https://bugzilla.gnome.org/show_bug.cgi?id=663174