GNOME Bugzilla – Bug 663121
guides are below rotate/transform/shear/perspective preview
Last modified: 2011-11-16 20:34:25 UTC
When using any of the tools rotate/transform/shear/perspective the guides are drawn bellow the preview of the tool. This is not how it works in 2.6.* version (tried out in 2.6.11-5 (debian testing)).
Regression -> 2.8
Here is the result of git bisect: f09be52c1b19188ef20170dd9c6cd927db94630b is the first bad commit commit f09be52c1b19188ef20170dd9c6cd927db94630b Author: Michael Natterer <mitch@gimp.org> Date: Sun Mar 27 16:40:41 2011 +0200 app: turn the transform preview into a GimpCanvasItem And remove all the complicated handling code entirely. This makes GimpTransformTool a lot less complex. As a nice side effect, the preview is now always 100% in sync with the grid and handles. :040000 040000 fdd9b2773b9581c4ebe8c35edf05626dc13d0ef2 a50f8ff1e7c3af7f95c105a9e5c6a664a12c5f93 M app bisect run success
Thanks, but I know exactly where the problem is and how to fix it. I'm just not entirely sure yet about the proper layering of canvas items. Sorry about the bisecting effort, I should have mentioned this in my first comment.
No problem, my CPU did the work while I watched some animu :)
Step one: move tool items below the software cursor commit ffc9948d6e2e99a0d65181774b628c2710923f8c Author: Michael Natterer <mitch@gimp.org> Date: Wed Nov 16 21:10:43 2011 +0100 app: add a canvas group for tool items so we can control where in the canvas item stack they appear. Put the group right below the software cursor. app/display/gimpdisplayshell-items.c | 24 ++++++++++++++++++++++++ app/display/gimpdisplayshell-items.h | 17 +++++++++++------ app/display/gimpdisplayshell.h | 1 + app/tools/gimpdrawtool.c | 4 ++-- app/tools/gimpsourcetool.c | 20 ++++++++++---------- app/tools/gimptool-progress.c | 4 ++-- 6 files changed, 50 insertions(+), 20 deletions(-)
Fixed in git: commit d38ded387d28173a342a7d475a39995271f7ca6e Author: Michael Natterer <mitch@gimp.org> Date: Wed Nov 16 21:32:29 2011 +0100 Bug 663121 - guides are below rotate/transform/shear/perspective preview Add a canvas item group for previews, and a small preview infrastructure to GimpDrawTool, and put the transform preview into the preview group, which is below all guides, grid and layer boundaries. app/display/gimpdisplayshell-items.c | 26 ++++++++++++++ app/display/gimpdisplayshell-items.h | 29 +++++++++------- app/display/gimpdisplayshell.h | 1 + app/tools/gimpdrawtool.c | 60 +++++++++++++++++++++++++++------ app/tools/gimpdrawtool.h | 6 +++ 5 files changed, 99 insertions(+), 23 deletions(-)