GNOME Bugzilla – Bug 663109
Online Glom: line breaks are ignored in multi-line text in the details view
Last modified: 2021-07-05 10:53:17 UTC
Created attachment 200348 [details] details view details cell mockup The License Text data in this document demonstrates the bug: http://bagu.org:8080/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=0 This will need to be addressed when the 'details-data' element is changed to non-editable text entry boxes. I've attached an example of what the 'details-cell' element could look like with text entry boxes. It's not a complete mockup but it's a good start.
Created attachment 201485 [details] table-based mockup with text entries as data cells This is a proper mockup of how I think the details view should look and how the HTML/CSS should work. I've tried to match Glom 1.20 as much as possible. A couple of points: * HTML tables need to be used to get the input text entry to span two columns when there's no Open button (like in Glom). * The text input boxes in different groups don't line up like they do in Glom. It should be possible to set the 'padding-right' of the details-label dynamically using GWT to make this alignment match Glom. See the comments in the HTML for details. I don't think this should be a priority right now.
Another thought: * Using text entries for the data cell will loose the ability to add URLs as anchor links. We're not currently do this but it's something that would be useful. This is just something to be aware of.
> * HTML tables need to be used to get the input text entry to span two columns > when there's no Open button (like in Glom). Yes, I am surprised that you were able to do so much so far without tables. My own experience with CSS-only layout suggests that tables are the right thing to use. > Using text entries for the data cell will loose the ability to add URLs as anchor links. Is there a GWT bug open somewhere about adding that feature?
(In reply to comment #3) > > Using text entries for the data cell will loose the ability to add URLs as > anchor links. > > Is there a GWT bug open somewhere about adding that feature? I'm not sure what feature you mean. When as URL string is added to a text entry (in HTML an input tag), clicking on the input box will add the edit cursor if we don't turn that off. We can override the click event to open the URL (in a new window) but that might not be what people expect. And then we'd need to decide what to do when editing support is added. How do we distinguish between a click to edit and a click to open the URL? Maybe the solution is to use an anchor tag instead of a text input box when URLs are detected. When editing support is added, we can add an edit button to the right of the URL (in the same place that the Open buttons are placed). Clicking the edit button would convert the anchor tag to a text box with the URL string loaded for editing. Just an idea though. Glom doesn't seem to do anything special for URLs right now so there's nothing to try to match.
(In reply to comment #3) > > * HTML tables need to be used to get the input text entry to span two columns > > when there's no Open button (like in Glom). > > Yes, I am surprised that you were able to do so much so far without tables. My > own experience with CSS-only layout suggests that tables are the right thing to > use. Yeah. I was hoping to use the CSS display property (table, table-row and table-cell) but it's specifically not possible to span multiple cells with these. So good old-fashioned tables it is.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/glom/-/issues/ Thank you for your understanding and your help.