After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662994 - Properly chain up to the class that implements a given vfunc.
Properly chain up to the class that implements a given vfunc.
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-29 13:10 UTC by Tomeu Vizoso
Modified: 2011-11-02 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Properly chain up to the class that implements a given vfunc. (3.76 KB, patch)
2011-10-29 13:10 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2011-10-29 13:10:44 UTC 
This is needed for example for so subclasses of GtkMenu can chain up from
::enter_notify_event to the implementation in GtkMenuShell.
Comment 1 Tomeu Vizoso 2011-10-29 13:10:46 UTC 
Created attachment 200250 [details] [review]
Properly chain up to the class that implements a given vfunc.
Comment 2 Benjamin Berg 2011-11-01 13:45:35 UTC 
This bug breaks a lot of custom widgets, as chaining up overridden signals does not work properly. As such, it currently prevents Sugar (and likely more applications/libraries) from being ported over to GTK+ 3.

I would consider this bug a blocker, as it is not always possible to work around this issue. The patch is working great as far as I can tell.
Comment 3 johnp 2011-11-01 15:32:00 UTC 
Comment on attachment 200250 [details] [review]
Properly chain up to the class that implements a given vfunc.

It looks ok to me though I don't know if it might break someone else.  Doesn't look harmful and we just branched stable so feel free to commit to master.
Comment 4 Tomeu Vizoso 2011-11-02 13:56:44 UTC 
(In reply to comment #3)
> (From update of attachment 200250 [details] [review])
> It looks ok to me though I don't know if it might break someone else.  Doesn't
> look harmful and we just branched stable so feel free to commit to master.

Well, if it breaks anything, we should add more tests :)
Comment 5 Tomeu Vizoso 2011-11-02 13:58:05 UTC 
Attachment 200250 [details] pushed as 2fd3aa9 - Properly chain up to the class that implements a given vfunc.