After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662914 - Reply to gnupg signed mails should be signed
Reply to gnupg signed mails should be signed
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
3.0.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-10-28 05:32 UTC by Yves-Alexis Perez
Modified: 2011-11-14 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (5.50 KB, patch)
2011-11-14 14:24 UTC, Milan Crha
committed Details | Review

Description Yves-Alexis Perez 2011-10-28 05:32:02 UTC
The summary says all. Basically when you reply to encrypted mail, the data is sensitive so the reply should be encrypted too. Selecting that by default makes sense.
Comment 1 Milan Crha 2011-11-11 10:03:13 UTC
Thanks for a bug report. This had been addresses in bug #545851. What is the message structure you are replying to, please? Seeing the change in the other bug then the functionality depends on message itself, thus to cover your case, the test should be extended for those types too.
Comment 2 Yves-Alexis Perez 2011-11-14 09:09:20 UTC
Are you sure it's related? #545851 seems to be only about sending mail and editing sent mails. 

In my case, I receive a GPG-signed and/or GPG-encrypted mail (wether inline or PGP/MIME). In this case, when replying, I think the reply should, by default, have the same security settings as the initial mail.
Comment 3 Milan Crha 2011-11-14 10:50:23 UTC
Yup, the change in the bug makes sure that options for Security in composer for Sign/Encrypt are checked if user replies to signed/encrypted message. If this works fine for you for non-inline signatures/encryptions, then fine. With inline signatures/encryptions it'll be slightly harder, and that case doesn't seem to be covered by the aforementioned bug.
Comment 4 Yves-Alexis Perez 2011-11-14 11:32:46 UTC
Well, then I can confirm it doesn't work for GPG mails, wether inline or GPG/MIME, in 3.0.
Comment 5 Milan Crha 2011-11-14 12:36:10 UTC
(In reply to comment #4)
> Well, then I can confirm it doesn't work for GPG mails, wether inline or
> GPG/MIME, in 3.0.

The applies my question from comment #1.
Comment 6 Yves-Alexis Perez 2011-11-14 13:26:55 UTC
Sent direct signed mail to Milan so he has the messages to work on.
Comment 7 Milan Crha 2011-11-14 13:30:18 UTC
Thanks, I can reproduce it too, and I found the reason, it's bug #607595 for signed messages. The gpg encrypted message should work, though (mine GPG key ID is F3C36A0D).
Comment 8 Yves-Alexis Perez 2011-11-14 13:34:37 UTC
(In reply to comment #7)
> Thanks, I can reproduce it too, and I found the reason, it's bug #607595 for
> signed messages. The gpg encrypted message should work, though (mine GPG key ID
> is F3C36A0D).

Indeed, encryption work. In my case, I disagree with Adam, I'd prefer to sign by default when people send me signed mail :) Not sure what we can do from now.
Comment 9 Milan Crha 2011-11-14 13:49:43 UTC
It sounds like a need for an option somewhere.
Comment 10 Milan Crha 2011-11-14 14:24:02 UTC
Created attachment 201370 [details] [review]
evo patch

for evolution;

This adds an option to Edit->Preferences->Composer Preferences, at the very bottom of that page.
Comment 11 Milan Crha 2011-11-14 14:25:21 UTC
Created commit 78a2a77 in evo master (3.3.2+)