After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662870 - Fix introspection annotations for GtkRadioToolButton
Fix introspection annotations for GtkRadioToolButton
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-27 18:06 UTC by Emmanuele Bassi (:ebassi)
Modified: 2011-10-28 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
radiotoolbutton: Fix the annotation for get_group() (909 bytes, patch)
2011-10-27 18:06 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
radiotoolbutton: Fix the introspection annotations (3.46 KB, patch)
2011-10-27 18:06 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2011-10-27 18:06:38 UTC 
Currently, it's pretty much broken, which is a shame, because GtkRadioButton works fine.
Comment 1 Emmanuele Bassi (:ebassi) 2011-10-27 18:06:40 UTC 
Created attachment 200125 [details] [review]
radiotoolbutton: Fix the annotation for get_group()

Use the same annotation used by gtk_radio_button_get_group().
Comment 2 Emmanuele Bassi (:ebassi) 2011-10-27 18:06:44 UTC 
Created attachment 200126 [details] [review]
radiotoolbutton: Fix the introspection annotations

Everything that deals with a group has to be fixed.

Plus, we have NULL checks without allowing NULL arguments; since NULL
arguments are perfectly fine, we can relax the argument checks.
Comment 3 Matthias Clasen 2011-10-28 16:09:11 UTC 
Review of attachment 200125 [details] [review]:

sure
Comment 4 Matthias Clasen 2011-10-28 16:09:52 UTC 
Review of attachment 200126 [details] [review]:

Looks fine
Comment 5 Emmanuele Bassi (:ebassi) 2011-10-28 16:43:46 UTC 
Attachment 200125 [details] pushed as 931a408 - radiotoolbutton: Fix the annotation for get_group()
Attachment 200126 [details] pushed as a77162e - radiotoolbutton: Fix the introspection annotations