After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662858 - Avoid warning when finalizing an GDBusObjectManagerClient that never got a name owner
Avoid warning when finalizing an GDBusObjectManagerClient that never got a na...
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-10-27 14:58 UTC by Aleksander Morgado
Modified: 2011-10-27 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix: Just skip the g_warn_if_fail() (1.45 KB, patch)
2011-10-27 14:59 UTC, Aleksander Morgado
accepted-commit_now Details | Review

Description Aleksander Morgado 2011-10-27 14:58:22 UTC
When finalizing a GDBusObjectManagerClient, we make sure that the 'on_control_proxy_g_signal' callback was setup as a signal handler; but that won't be the case when a GDBusObjectManagerClient is created and never gets a name owner.

GLib-GIO-WARNING **: (/build/buildd/glib2.0-2.31.0/./gio/gdbusobjectmanagerclient.c:206):g_dbus_object_manager_client_finalize: runtime check failed: (g_signal_handlers_disconnect_by_func (manager->priv->control_proxy, on_control_proxy_g_signal, manager) == 1)
Comment 1 Aleksander Morgado 2011-10-27 14:59:59 UTC
Created attachment 200112 [details] [review]
Fix: Just skip the g_warn_if_fail()
Comment 2 David Zeuthen (not reading bugmail) 2011-10-27 15:18:02 UTC
Comment on attachment 200112 [details] [review]
Fix: Just skip the g_warn_if_fail()

Sure. Please also cherry-pick on the glib-2-30 branch. Thanks.
Comment 3 Aleksander Morgado 2011-10-27 16:36:16 UTC
Done.