After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662839 - gtk: Fix XIGrabKeycode usage
gtk: Fix XIGrabKeycode usage
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-27 10:13 UTC by Bastien Nocera
Modified: 2011-10-28 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk: Fix XIGrabKeycode usage (1.10 KB, patch)
2011-10-27 10:13 UTC, Bastien Nocera 		needs-work Details | Review

Description Bastien Nocera 2011-10-27 10:13:27 UTC 
As mentioned by Peter in:
https://bugzilla.gnome.org/show_bug.cgi?id=340720
Comment 1 Bastien Nocera 2011-10-27 10:13:53 UTC 
Created attachment 200086 [details] [review]
gtk: Fix XIGrabKeycode usage

A modifier of "0" is still a modifier and must be submitted normally.
A num_modifiers of 0 is essentially a noop in the server.

As mentioned by Peter Hutterer <peter.hutterer@who-t.net>
Comment 2 Matthias Clasen 2011-10-27 18:41:16 UTC 
Review of attachment 200086 [details] [review]:

Note that the same code is around for both grab and ungrab. Make sure to fix them both
Comment 3 Bastien Nocera 2011-10-28 11:05:23 UTC 
Done, for both grab and ungrab, not sure how I missed that having read the code before.

commit 0888e6f4854507600bdb72fe2eea65496be98407
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Oct 27 11:09:26 2011 +0100

    gtk: Fix XIGrabKeycode usage
    
    A modifier of "0" is still a modifier and must be submitted normally.
    A num_modifiers of 0 is essentially a noop in the server.
    
    As mentioned by Peter Hutterer <peter.hutterer@who-t.net>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662839