After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662800 - user-menu: Disable combo box if no accounts are enabled
user-menu: Disable combo box if no accounts are enabled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 662799
Blocks:
 
 
Reported: 2011-10-26 20:26 UTC by Florian Müllner
Modified: 2011-11-15 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user-menu: Disable combo box if no accounts are enabled (2.23 KB, patch)
2011-10-26 20:27 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-10-26 20:26:55 UTC
See patch.
Comment 1 Florian Müllner 2011-10-26 20:27:00 UTC
Created attachment 200058 [details] [review]
user-menu: Disable combo box if no accounts are enabled

If no telepathy accounts have been set up or enabled, the IM status
chooser won't have any effect. To avoid confusing behavior, make
the status selector insensitive in that case.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-26 20:36:06 UTC
Review of attachment 200058 [details] [review]:

Looks code correct to me, just needs to pass ui-review.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-11-05 21:04:11 UTC
I think this is fine to push without ui-review.
Comment 4 Florian Müllner 2011-11-15 12:56:07 UTC
Attachment 200058 [details] pushed as e279ef1 - user-menu: Disable combo box if no accounts are enabled