After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662776 - vc1parser: do not overwrite buffer
vc1parser: do not overwrite buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-26 15:33 UTC by Vincent Penquerc'h
Modified: 2011-11-03 08:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vc1parser: do not overwrite buffer (1.50 KB, patch)
2011-10-26 15:33 UTC, Vincent Penquerc'h 		committed Details | Review
tests: make const data const (5.06 KB, patch)
2011-10-26 15:33 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-10-26 15:33:07 UTC 
Also add a check for the number of items to read.
Comment 1 Vincent Penquerc'h 2011-10-26 15:33:09 UTC 
Created attachment 200029 [details] [review]
vc1parser: do not overwrite buffer

I do not know the bitstream format, but this seems likely
to be what was intended. Also add a check on the number of
items to read.
Comment 2 Vincent Penquerc'h 2011-10-26 15:33:12 UTC 
Created attachment 200030 [details] [review]
tests: make const data const
Comment 3 Sebastian Dröge (slomo) 2011-11-03 08:46:14 UTC 
commit 0a170110ea18c112ebe18fcd0589f4ccf93def70
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Oct 26 16:31:39 2011 +0100

    tests: make const data const
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662776

commit ca2f96caac718c4d466e0e619f2e48471d7dbb24
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Oct 26 16:29:35 2011 +0100

    vc1parser: do not overwrite buffer
    
    I do not know the bitstream format, but this seems likely
    to be what was intended. Also add a check on the number of
    items to read.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662776