After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662762 - critical when HTTP request fails
critical when HTTP request fails
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-26 13:01 UTC by Sam Thursfield
Modified: 2011-11-01 22:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grl-net: Fix crashes in SoupRequest error case (2.47 KB, patch)
2011-10-26 13:02 UTC, Sam Thursfield 		none Details | Review

Description Sam Thursfield 2011-10-26 13:01:43 UTC 
Patch attached to fix a critical and a segfault in with the SoupRequest-based code in grl-net-wc, occuring when the request fails.
Comment 1 Sam Thursfield 2011-10-26 13:02:05 UTC 
Created attachment 200019 [details] [review]
grl-net: Fix crashes in SoupRequest error case
Comment 2 Simon Pena 2011-10-27 08:00:57 UTC 
Hi, thanks for the patches. We'll review them and push them asap.
Comment 3 Víctor Manuel Jáquez Leal 2011-10-27 08:57:43 UTC 
Review of attachment 200019 [details] [review]:

The changes in functions reply_cb() and grl_net_wc_request_finish() seem OK to me, but the one in get_url_now(), I don't get the reason of it. g_simple_async_result_set_op_res_gpointer() doesn't change the content of the RequestResult. Can you confirm?
Comment 4 Sam Thursfield 2011-10-31 18:48:23 UTC 
You're correct, the change in get_url_now () doesn't have any effect.

I've pushed the patch before realising, please accept my apologies if you'd rather I waited
Comment 5 Simon Pena 2011-11-01 20:29:20 UTC 
I've pushed this to 0.1.x branch as well. Thanks!
Comment 6 Simon Pena 2011-11-01 22:01:21 UTC 
I'm closing this as FIXED: the changes are now available in both the development and stable branches.