After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662747 - gnome-shell hang when searching in overview
gnome-shell hang when searching in overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-26 09:30 UTC by Tim Lauridsen
Modified: 2012-02-07 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Buggy and OK themes - Examples (15.12 KB, application/x-gzip)
2011-11-18 10:31 UTC, Tsu Jan
  Details
iconGrid: Don't enter an infinite loop (1.11 KB, patch)
2011-11-19 20:28 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Tim Lauridsen 2011-10-26 09:30:00 UTC
The issue happens only using a alternate gnome-shell theme 
(user-theme extension & gnome-tweak-tool)

If you change you theme and hit the windows key to get to the overview and start typing, then gnome-shell hangs, you can switch to another terminal and kill the gnome-shell process and it will auto start and be working until you search again.

I am running gnome-shell 3.2.1 in Fedora 16.

gnome-shell-3.2.1-1.fc16.x86_64

It don't matter what theme you are using, as long it is not the default one.

It was working fine in Fedora 15 with Gnome 3.0.x
Comment 1 Tim Lauridsen 2011-10-26 09:53:07 UTC
Look like it is caused by the themes i use i not compatible with gnome-shell 3.2.x

http://gnome-shell.deviantart.com/blog/45159138/

But I think that gnome-shell should not hang on a problem with a theme :)
Comment 2 Tsu Jan 2011-11-17 07:26:32 UTC
That's definitely caused by an incompatible theme. After rewriting my old theme (which I'd made for gnome-shell 3.0.2) with reference to the new default theme, I see no shell hang anymore when searching.
Comment 3 Milan Bouchet-Valat 2011-11-17 10:07:15 UTC
Could you try to find what are the exact parts of you changes that made the bug disappear?
Comment 4 Tsu Jan 2011-11-17 20:54:16 UTC
First I tried to find those parts to no avail. I was especially suspicious about the parts related to searching but changing them had no effect. Then I started with the default theme and changed it block by block, without removing any block, and I succeeded. Sorry for not finding any clue :(
Comment 5 Milan Bouchet-Valat 2011-11-18 10:07:46 UTC
(In reply to comment #4)
> First I tried to find those parts to no avail. I was especially suspicious
> about the parts related to searching but changing them had no effect. Then I
> started with the default theme and changed it block by block, without removing
> any block, and I succeeded. Sorry for not finding any clue :(
Thanks. What do you mean by "succeeded"? You say you didn't find anything, and though you succeeded? ;-)

Do you have a theme file that still triggers the bug?
Comment 6 Tsu Jan 2011-11-18 10:30:14 UTC
> What do you mean by "succeeded"?

I succeeded in recreating my theme so that it doesn't make GNOME-Shell freeze when the user types in the search entry.

> Do you have a theme file ...
I attach a buggy and an OK theme with almost the same look.
Comment 7 Tsu Jan 2011-11-18 10:31:12 UTC
Created attachment 201653 [details]
Buggy and OK themes - Examples
Comment 8 Tsu Jan 2011-11-19 20:09:42 UTC
Just a guess: doesn't an "incompatible" theme trigger this bug because it lacks the newly introduced "contact" blocks?
Comment 9 Jasper St. Pierre (not reading bugmail) 2011-11-19 20:28:12 UTC
Created attachment 201715 [details] [review]
iconGrid: Don't enter an infinite loop

If both spacing and -shell-grid-item-size are 0, as they would be with nothing
setting them, we enter an infinite loop where we try to compute the layout.
Avoid the situation entirely by defaulting -shell-grid-item-size to a sane
value instead of 0.


Nice catch.
Comment 10 Owen Taylor 2012-01-26 19:52:48 UTC
Review of attachment 201715 [details] [review]:

OK, though we generally do not and cannot handle CSS files that are missing required parameters - GNOME Shell is not themable.
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-02-07 22:40:53 UTC
Attachment 201715 [details] pushed as 27b3499 - iconGrid: Don't enter an infinite loop